cleanup: remove the *san Cargo features from std

[japaric]

these belong to a previous iteration of the sanitizer implementation

r? @alexcrichton
cc @whitequark

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[alexcrichton]

@bors: r+

Thanks!

[bors]

📌 Commit d22891e has been approved by alexcrichton

[frewsxcv]

This PR might have caused this issue: https://travis-ci.org/rust-lang/rust/jobs/202521389

[bors]

⌛ Testing commit d22891e with merge 1d20fc1...

[bors]

💔 Test failed - status-travis

[japaric]

command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "-j" "4" "--target" "arm-unknown-linux-gnueabihf" "--release" "--locked" "--manifest-path" "/checkout/src/rustc/std_shim/Cargo.toml" "--features" "panic-unwind jemalloc backtrace" "-p" "std_shim:0.0.0" "-p" "core:0.0.0" "-p" "std:0.0.0" "-p" "std_unicode:0.0.0" "-p" "rand:0.0.0" "-p" "collections:0.0.0" "-p" "panic_abort:0.0.0" "-p" "compiler_builtins:0.0.0" "-p" "unwind:0.0.0" "-p" "rustc_asan:0.0.0" "-p" "rustc_msan:0.0.0" "-p" "rustc_tsan:0.0.0" "-p" "alloc:0.0.0" "-p" "rustc_lsan:0.0.0" "-p" "alloc_system:0.0.0" "-p" "libc:0.0.0" "--no-run" "--" "--quiet"

This looks wrong because rustc_asan and friends are only dependencies of std on x86_64 Linux but this is testing for arm-linux. It seems that bootstrap has build the dependency graph of std assuming that the target is x86_64-linux. bootstrap is using cargo metadata to build the dependency graph and that contains target information so this seems fixable. I'll take a look.

[japaric]

If I'm reding this correctly, bootstrap uses cargo metadatas resolve field which, I think, contains the dependency graph that has been resolved for the host -- we can't use that one because that's e.g. for x86_64-linux but we want the dep graph for arm-linux.

cargo metadata also contains a "non resolved" version which seems to be pretty much a verbatim copy of the involved Cargo.tomls. That version distinguishes between dependencies and target.*.dependencies. We could use that "non resolved" version but the "target" information is represented as, e.g., null, "cfg(os = "windows")" and "x86_64-unknown-linux-gnu". The second form, with the cfg, seem like it's going to be difficult to dealt with. We'll have to replicate some of Cargo's cfg logic :-/.

A much simpler but hacky solution would be to blacklist rustc_asan and company in check.rs; that way we could filter away those crates so they are never passed to the cargo test command shown above.

@alexcrichton thoughts? ^

[alexcrichton]

@japaric I think the easiest solution would be to add this to all sanitizer Cargo.toml, right?

[lib]
test = false

The lib isn't intended to be unit tested, right?

[japaric]

Oh, is that enough? OK. r? @alexcrichton

[alexcrichton]

@bors: r+

[bors]

📌 Commit 2496f8a has been approved by alexcrichton

[bors]

⌛ Testing commit 2496f8a with merge 98b8826...

[bors]

💔 Test failed - status-travis

[alexcrichton]

@bors: retry * network error

…

On Thu, Feb 23, 2017 at 6:46 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/204569095> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39860 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95JO0W0-MOpIsjhMc8EVDNlnLEnVpks5rfX-RgaJpZM4MCToI> .

[bors]

☔ The latest upstream changes (presumably #39851) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

🔒 Merge conflict

[alexcrichton]

ping @japaric (rebase)

[japaric]

@alexcrichton rebased

[alexcrichton]

@bors: r+

[bors]

📌 Commit 28baa27 has been approved by alexcrichton

[bors]

⌛ Testing commit 28baa27 with merge ee60afa...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ee60afa to master...