Uh oh!
There was an error while loading. Please reload this page.
Reenable linkchecker for books - #39976
Merged
Merged
Conversation
This reverts commit 7f1d1c6. The original commit was created because mdBook and rustdoc had different generation algorithms for header links; now with rust-lang#39966 , the algorithms are the same. So let's undo this change. ... when I came across this problem, I said "eh, this isn't fun, but it doesn't take that long." I probably should have just actually taken the time to fix upstream, given that they were amenable. Oh well!
rust-highfive
commented
Feb 20, 2017
Contributor
@steveklabnik: no appropriate reviewer found, use r? to override |
This was referenced Feb 20, 2017
steveklabnik
commented
Feb 20, 2017
ContributorAuthor
r? @frewsxcv |
This was referenced Feb 20, 2017
steveklabnikforce-pushed
the
reenable-book-linkchecker
branch
from
February 20, 2017 15:25
6258ae1 to
5a42c59Comparefrewsxcv
commented
Feb 20, 2017
Contributor
Travis: |
frewsxcv
commented
Feb 20, 2017
Contributor
r=me with lockfile thing sorted out |
ContributorAuthor
hrm, I don't understand why it's doing that; tidy passes for me locally. EDIT: Oh, I forgot to commit the lockfile, dunno why... |
steveklabnikforce-pushed
the
reenable-book-linkchecker
branch
from
February 20, 2017 16:03
5a42c59 to
f5951afComparesteveklabnik
commented
Feb 20, 2017
ContributorAuthor
@bors: r=frewsxcv |
bors
commented
Feb 20, 2017
Collaborator
📌 Commit f5951af has been approved by |
Previously, mdBook used JavaScript to add header links, so we skipped checking the book. As of rust-lang#39966, it no longer does, so we can start checking again. There is a twist, though: it uses name instead of id, so let's test for both. They're both valid links anyway, so it's good to have the checker check anyway.
This brings in a needed bugfix.
steveklabnikforce-pushed
the
reenable-book-linkchecker
branch
from
February 20, 2017 16:18
f5951af to
010a28dComparesteveklabnik
commented
Feb 20, 2017
ContributorAuthor
@bors: r=frewsxcv (I left in a warning by accident) |
bors
commented
Feb 20, 2017
Collaborator
📌 Commit 010a28d has been approved by |
ollie27
commented
Feb 20, 2017
Contributor
Why have you used the |
steveklabnik
commented
Feb 20, 2017
ContributorAuthor
That is what mdbook has always used for these links. |
ollie27
commented
Feb 20, 2017
Contributor
Is there a good reason for that? I'm pretty sure |
steveklabnik
commented
Feb 20, 2017
ContributorAuthor
You should file a bug on mdbook about it. |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 20, 2017
…ker, r=frewsxcv Reenable linkchecker for books In some senses, this is a revert of rust-lang@cacb3bc#diff-b64563d143f859565c8357a28ef81101R212; we disabled linkchecker for the book because the links were added by JavaScript. Now, that's fixed upstream, and so we can re-enable the checker. This also involves two other fixes: we have to check for `name`s as well as `id`s for links, and the linking algorithm of mdBook changed to the same as rustdoc's, so we change some links back. ~~~This isn't quite ready yet; it's [depending on a PR of mine to mdBook](https://github.com/azerupi/mdBook/pull/209). After that's released, this should be the last of these kinds of shenanigans~~~ 😄 This is good to go 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some senses, this is a revert of cacb3bc#diff-b64563d143f859565c8357a28ef81101R212; we disabled linkchecker for the book because the links were added by JavaScript. Now, that's fixed upstream, and so we can re-enable the checker.
This also involves two other fixes: we have to check for
names as well asids for links, and the linking algorithm of mdBook changed to the same as rustdoc's, so we change some links back.