[MIR] improve operand lifetimes by arielb1 · Pull Request #40133 · rust-lang/rust

arielb1 · 2017-02-27T22:11:17Z

r? @eddyb

arielb1 · 2017-02-27T22:14:30Z

cc @nagisa

eddyb · 2017-02-27T22:21:53Z

@bors r+

bors · 2017-02-27T22:21:55Z

📌 Commit 7f8529d has been approved by eddyb

eddyb · 2017-02-28T10:15:03Z

@bors r-

/checkout/src/test/codegen/lifetime_start_end.rs:39:11: error: expected string not found in input
// CHECK: [[E_b:%[0-9]+]] = bitcast %"core::option::Option<i32>"** %b to i8*
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/lifetime_start_end.ll:37:2: note: scanning from here
%9 = bitcast i32* %c to i8*
^

arielb1 · 2017-02-28T11:16:07Z

@bors r=eddyb

bors · 2017-02-28T11:16:08Z

📌 Commit e4458de has been approved by eddyb

@eddyb

[MIR] improve operand lifetimes r? @eddyb

frewsxcv · 2017-03-02T17:54:55Z

Could this failure be related? #40211 (comment)

frewsxcv · 2017-03-02T17:55:56Z

Yes, Travis in this PR also has the fail

@bors r-

This reduces the number of dynamic drops in libstd from 1141 to 899. However, without this change, the next patch would have created much more dynamic drops. A basic merge unswitching hack reduced the number of dynamic drops to 644, with no effect on stack usage. I should be writing a more dedicated drop unswitching pass. No performance measurements.

arielb1 · 2017-03-03T00:41:43Z

@bors r=eddyb

bors · 2017-03-03T00:41:44Z

📌 Commit 31faaf2 has been approved by eddyb

bors · 2017-03-03T02:29:57Z

⌛ Testing commit 31faaf2 with merge d6e5b10...

bors · 2017-03-03T03:15:50Z

💔 Test failed - status-appveyor

In MIR construction, operands need to live exactly until they are used, which is during the (sub)expression that made the call to `as_operand`. Before this PR, operands lived until the end of the temporary scope, which was sometimes unnecessarily longer and sometimes too short. Fixesrust-lang#38669.

arielb1 · 2017-03-03T11:54:47Z

Rebase damage.

@bors r=eddyb

bors · 2017-03-03T11:54:48Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Reduce std_unicode’s public API #40189

bors · 2017-03-03T11:54:48Z

📌 Commit 31faaf2 has been approved by eddyb

arielb1 · 2017-03-03T11:55:26Z

@bors r=eddyb f99f1f8

arielb1 · 2017-03-03T11:55:48Z

@bors r-

arielb1 · 2017-03-03T11:56:13Z

@bors r=eddyb

bors · 2017-03-03T11:56:14Z

📌 Commit f99f1f8 has been approved by eddyb

bors · 2017-03-03T11:56:21Z

⌛ Testing commit f99f1f8 with merge b2a424f...

bors · 2017-03-03T12:17:16Z

💔 Test failed - status-appveyor

arielb1 · 2017-03-03T12:20:05Z

C:/projects/rust/mingw32/bin/ar.exe: unable to rename '../../../libLLVMSparcDesc.a'; reason: Permission denied

Looks spurious

@bors retry

bors · 2017-03-03T13:12:12Z

⌛ Testing commit f99f1f8 with merge f0b5145...

@eddyb

[MIR] improve operand lifetimes r? @eddyb

bors · 2017-03-03T15:11:55Z

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing f0b5145 to master...

rust-highfive assigned eddyb Feb 27, 2017

eddyb approved these changes Feb 27, 2017
View reviewed changes

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 2, 2017
Rollup merge ofrust-lang#40133- arielb1:operand-lifetimes, r=eddyb
21d61ff
[MIR] improve operand lifetimes r? @eddyb

frewsxcv mentioned this pull request Mar 2, 2017
Rollup of 6 pull requests #40211
Closed

arielb1 force-pushed the operand-lifetimes branch from e4458de to 31faaf2Compare March 3, 2017 00:33

arielb1 added 3 commits March 3, 2017 13:54

fix codegen test
3ffa971

work around LLVM PR#32123
f99f1f8

arielb1 force-pushed the operand-lifetimes branch from 31faaf2 to f99f1f8Compare March 3, 2017 11:54

bors added a commit that referenced this pull request Mar 3, 2017
Auto merge of#40133- arielb1:operand-lifetimes, r=eddyb
f0b5145
[MIR] improve operand lifetimes r? @eddyb

bors merged commit f99f1f8 into rust-lang:masterMar 3, 2017

bors mentioned this pull request Mar 3, 2017
Implement ? in catch expressions #40229
Merged

arielb1 mentioned this pull request Mar 17, 2017
RefCell complains two mutable borrows present when only one exist on armv7-unknown-linux-gnueabihf #40593
Closed

arielb1 mentioned this pull request Mar 28, 2017
Current beta breaks my build that works on stable #40573
Closed

Uh oh!

Uh oh!

Conversation

arielb1 commented Feb 27, 2017

Uh oh!

arielb1 commented Feb 27, 2017

Uh oh!

eddyb commented Feb 27, 2017

Uh oh!

bors commented Feb 27, 2017

Uh oh!

eddyb commented Feb 28, 2017

Uh oh!

arielb1 commented Feb 28, 2017

Uh oh!

bors commented Feb 28, 2017

Uh oh!

frewsxcv commented Mar 2, 2017

Uh oh!

frewsxcv commented Mar 2, 2017

Uh oh!

arielb1 commented Mar 3, 2017

Uh oh!

bors commented Mar 3, 2017

Uh oh!

bors commented Mar 3, 2017

Uh oh!

bors commented Mar 3, 2017

Uh oh!

arielb1 commented Mar 3, 2017

Uh oh!

bors commented Mar 3, 2017

Uh oh!

bors commented Mar 3, 2017

Uh oh!

arielb1 commented Mar 3, 2017

Uh oh!

arielb1 commented Mar 3, 2017

Uh oh!

arielb1 commented Mar 3, 2017

Uh oh!

bors commented Mar 3, 2017

Uh oh!

bors commented Mar 3, 2017

Uh oh!

bors commented Mar 3, 2017

Uh oh!

arielb1 commented Mar 3, 2017

Uh oh!

bors commented Mar 3, 2017

Uh oh!

bors commented Mar 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants