Add Utf8Error::error_len, to help incremental and/or lossy decoding. by SimonSapin · Pull Request #40212 · rust-lang/rust

SimonSapin · 2017-03-02T17:29:27Z

Without this, code outside of the standard library needs to reimplement most of the logic from_utf8 to interpret the bytes after valid_up_to().

rust-highfive · 2017-03-02T17:29:47Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

SimonSapin · 2017-03-02T17:31:13Z

This is a new standard library public API that I’m hoping to stabilize eventually. But it’s a small extension of an existing feature rather than an entirely new feature, so it seemed appropriate to submit without an RFC.

sfackler · 2017-03-02T18:29:52Z

This seems reasonable to me and I agree that an RFC isn't necessary. cc @rust-lang/libs

@rfcbot fcp merge

rfcbot · 2017-03-02T18:29:52Z

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

bors · 2017-03-03T11:56:50Z

☔ The latest upstream changes (presumably #40189) made this pull request unmergeable. Please resolve the merge conflicts.

SimonSapin · 2017-03-03T11:59:44Z

Rebased.

SimonSapin · 2017-03-06T21:20:28Z

After trying it I’ve pushed another commit to change the proposed API:

Replace Utf8Error::resume_from with Utf8Error::error_len
Their relationship is:
resume_from = error_len.map(|l| l + valid_up_to)
error_len is always one of None, Some(1), Some(2), or Some(3).
When I started using resume_from I almost always ended up subtracting valid_up_to to obtain error_len. Therefore the latter is what should be provided in the first place.

re r? @BurntSushi @Kimundi @alexcrichton @aturon @brson @sfackler

alexcrichton · 2017-03-07T15:20:57Z

Seems fine by me!

aturon · 2017-03-13T21:08:53Z

@bors: r+

bors · 2017-03-13T21:08:54Z

📌 Commit 354f092 has been approved by aturon

SimonSapin · 2017-03-13T22:54:59Z

Added a tracking issue number to the PR. @aturon re-r?

alexcrichton · 2017-03-13T22:57:25Z

@bors: r=aturon

bors · 2017-03-13T22:57:26Z

📌 Commit 5b3dbd8 has been approved by aturon

bors · 2017-03-14T02:19:54Z

🔒 Merge conflict

Without this, code outside of the standard library needs to reimplement most of the logic `from_utf8` to interpret the bytes after `valid_up_to()`.

Their relationship is: * `resume_from = error_len.map(|l| l + valid_up_to)` * error_len is always one of None, Some(1), Some(2), or Some(3). When I started using resume_from I almost always ended up subtracting valid_up_to to obtain error_len. Therefore the latter is what should be provided in the first place.

SimonSapin · 2017-03-14T09:05:53Z

Rebased.

I don’t understand how this happened, but git seemed convinced that my commits wanted to remove the src/doc/reference and src/doc/nomicon submodules that I think didn’t exist at the time and have been added since. This was the only "conflict".

@aturon or @alexcrichton r?

alexcrichton · 2017-03-14T14:37:52Z

~submodules~

@bors: r=aturon

bors · 2017-03-14T14:37:53Z

📌 Commit 73370c5 has been approved by aturon

bors · 2017-03-14T14:38:03Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Fix race condition in fs::create_dir_all #39799

bors · 2017-03-14T14:38:04Z

📌 Commit 73370c5 has been approved by aturon

bors · 2017-03-14T18:45:25Z

⌛ Testing commit 73370c5 with merge ae118b1...

frewsxcv · 2017-03-15T03:21:30Z

@bors retry

bors · 2017-03-15T07:04:24Z

⌛ Testing commit 73370c5 with merge 11a3376...

Add Utf8Error::error_len, to help incremental and/or lossy decoding. Without this, code outside of the standard library needs to reimplement most of the logic `from_utf8` to interpret the bytes after `valid_up_to()`.

bors · 2017-03-15T09:53:17Z

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 11a3376 to master...

rust-highfive assigned sfackler Mar 2, 2017

sfackler added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 2, 2017

SimonSapin force-pushed the utf8error-resume-from branch from 3e1601a to 7e95d5bCompare March 3, 2017 11:59

SimonSapin mentioned this pull request Mar 4, 2017
Tracking issue for Read::chars #27802
Closed

SimonSapin changed the title ~~Add Utf8Error::resume_from, to help incremental and/or lossy decoding.~~Add Utf8Error::error_len, to help incremental and/or lossy decoding.Mar 6, 2017

SimonSapin force-pushed the utf8error-resume-from branch from 5ea9b0e to 354f092Compare March 6, 2017 21:15

rust-highfive assigned BurntSushi and unassigned sfackler Mar 6, 2017

SimonSapin mentioned this pull request Mar 13, 2017
Tracking issue for the Utf8Error::error_len method #40494
Closed

SimonSapin added 3 commits March 14, 2017 10:02

Add Utf8Error::resume_from, to help incremental and/or lossy decoding.
1820442
Without this, code outside of the standard library needs to reimplement most of the logic `from_utf8` to interpret the bytes after `valid_up_to()`.

Add tracking issue number for Utf8Error::error_len
73370c5

SimonSapin force-pushed the utf8error-resume-from branch from 5b3dbd8 to 73370c5Compare March 14, 2017 09:03

bors merged commit 73370c5 into rust-lang:masterMar 15, 2017

SimonSapin deleted the utf8error-resume-from branch March 15, 2017 13:29

bluetech mentioned this pull request Mar 25, 2017
Miscellaneous improvements snapview/tungstenite-rs#7
Merged

Uh oh!

Uh oh!

Conversation

SimonSapin commented Mar 2, 2017

Uh oh!

rust-highfive commented Mar 2, 2017

Uh oh!

SimonSapin commented Mar 2, 2017

Uh oh!

sfackler commented Mar 2, 2017

Uh oh!

rfcbot commented Mar 2, 2017• edited by aturon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Mar 3, 2017

Uh oh!

SimonSapin commented Mar 3, 2017

Uh oh!

SimonSapin commented Mar 6, 2017

Uh oh!

alexcrichton commented Mar 7, 2017

Uh oh!

aturon commented Mar 13, 2017

Uh oh!

bors commented Mar 13, 2017

Uh oh!

SimonSapin commented Mar 13, 2017

Uh oh!

alexcrichton commented Mar 13, 2017

Uh oh!

bors commented Mar 13, 2017

Uh oh!

bors commented Mar 14, 2017

Uh oh!

SimonSapin commented Mar 14, 2017

Uh oh!

alexcrichton commented Mar 14, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Mar 14, 2017

Uh oh!

bors commented Mar 14, 2017

Uh oh!

bors commented Mar 14, 2017

Uh oh!

bors commented Mar 14, 2017

Uh oh!

frewsxcv commented Mar 15, 2017

Uh oh!

bors commented Mar 15, 2017

Uh oh!

bors commented Mar 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

rfcbot commented Mar 2, 2017•
edited by aturon
Loading

alexcrichton commented Mar 14, 2017•
edited
Loading