Skip to content

Add compile fail test for stmt_expr_attributes - #40252

Merged
bors merged 1 commit into
rust-lang:masterfrom
topecongiro:compile-fail-test-cfg-stmt-expr
Mar 5, 2017
Merged

Add compile fail test for stmt_expr_attributes#40252
bors merged 1 commit into
rust-lang:masterfrom
topecongiro:compile-fail-test-cfg-stmt-expr

Conversation

@topecongiro

@topecongirotopecongiro commented Mar 4, 2017

Copy link
Copy Markdown
Contributor

Adds a missing feature gate test for stmt_expr_attributes. Issue #39059.

@rust-highfive

rust-highfive commented Mar 4, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@est31est31 mentioned this pull request Mar 4, 2017
Closed
20 tasks
@petrochenkov

petrochenkov commented Mar 4, 2017

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 4, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 0ab882b has been approved by petrochenkov

@bors

bors commented Mar 4, 2017

Copy link
Copy Markdown
Collaborator

🔒 Merge conflict

@topecongiro
topecongiroforce-pushed the compile-fail-test-cfg-stmt-expr branch from 0ab882b to 255d59fCompareMarch 5, 2017 05:41
@petrochenkov

petrochenkov commented Mar 5, 2017

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 5, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 255d59f has been approved by petrochenkov

@bors

bors commented Mar 5, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 255d59f with merge 6b76c9e...

bors added a commit that referenced this pull request Mar 5, 2017
@bors
Auto merge of#40252- topecongiro:compile-fail-test-cfg-stmt-expr, r…
6b76c9e
…=petrochenkov
Add compile fail test for stmt_expr_attributes
Adds a missing feature gate test for `stmt_expr_attributes`. Issue #39059.
@bors

bors commented Mar 5, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 6b76c9e to master...

@bors
bors merged commit 255d59f into rust-lang:masterMar 5, 2017
@borsbors mentioned this pull request Mar 5, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@topecongiro@rust-highfive@petrochenkov@bors@alexcrichton