Handle extern functions and statics in save-analysis by nrc · Pull Request #40348 · rust-lang/rust

nrc · 2017-03-08T05:07:16Z

r? @eddyb

eddyb · 2017-03-08T11:25:50Z

@bors r+

bors · 2017-03-08T11:25:51Z

📌 Commit 0aceb99 has been approved by eddyb

bors · 2017-03-09T10:43:07Z

🔒 Merge conflict

alexcrichton · 2017-03-09T15:04:55Z

@bors: retry

@eddyb

Handle extern functions and statics in save-analysis r? @eddyb

arielb1 · 2017-03-10T11:31:10Z

thread 'rustc' panicked at 'Name not in signature?', /checkout/src/libcore/option.rs:785
note: Run with `RUST_BACKTRACE=1` for a backtrace.
Build failed, waiting for other jobs to finish...
error: Could not compile `rustc_llvm`.

arielb1 · 2017-03-10T11:31:28Z

@bors r-

nrc · 2017-03-16T01:16:05Z

@bors: r=@eddyb

bors · 2017-03-16T01:16:06Z

📌 Commit 4cf22cb has been approved by @eddyb

@eddyb

Handle extern functions and statics in save-analysis r? @eddyb

@eddyb

Handle extern functions and statics in save-analysis r? @eddyb

Rollup of 22 pull requests - Successful merges: #40241, #40346, #40348, #40377, #40398, #40409, #40441, #40445, #40509, #40521, #40523, #40532, #40538, #40564, #40581, #40583, #40588, #40589, #40590, #40603, #40611, #40621 - Failed merges: #40501, #40541

arielb1 · 2017-03-19T00:13:42Z

Still broken, same error:

thread 'rustc' panicked at 'Name not in signature?', /checkout/src/libcore/option.rs:785
note: Run with `RUST_BACKTRACE=1` for a backtrace.
Build failed, waiting for other jobs to finish...
error: Could not compile `rustc_llvm`.

@bors r-

nrc · 2017-03-19T02:34:08Z

@arielb1 how do I repro this? We're passing everything on Travis and running x.py test locally is fine too.

arielb1 · 2017-03-19T08:33:46Z

@nrc

Try doing ../x.py dist.

nrc · 2017-03-19T19:12:45Z

Nope, dist works fine. This looks like a specific save-analysis error, but the only place (iirc) we run save-analysis in the the test suite is in two tests in run-make - both of which run fine. My only thought is that this is due to a combination of this PR and another one in the rollup? But I don't see anything that would affect save-analysis in the rollup. I've rebased and am running tests again locally to see if I can repro...

nrc · 2017-03-27T04:13:47Z

@bors: r=eddyb

Yet again, I still can't repro any failure with test or dist (which suggests that the problem is not with another PR, but perhaps platform specific?). I don't see any way to debug this further without bors having a run over it. I suppose this will fail and waste some time, but otherwise I'm stuck.

Please don't rollup this PR (or r- it).

bors · 2017-03-27T04:13:48Z

📌 Commit 158079e has been approved by eddyb

bors · 2017-03-27T04:41:44Z

⌛ Testing commit 158079e with merge 22ff5e0...

bors · 2017-03-27T05:05:59Z

💔 Test failed - status-appveyor

nrc · 2017-03-30T08:33:10Z

@bors: retry

bors · 2017-03-30T09:25:10Z

⌛ Testing commit 8f6b68c with merge e126c17...

bors · 2017-03-30T09:44:09Z

💔 Test failed - status-travis

nrc · 2017-04-04T04:08:54Z

@bors: r=eddyb

bors · 2017-04-04T04:08:55Z

📌 Commit d76daf5 has been approved by eddyb

bors · 2017-04-04T20:22:06Z

⌛ Testing commit d76daf5 with merge 1f41ec8...

frewsxcv · 2017-04-04T20:23:06Z

@bors retry

prioritizing rollup

bors · 2017-04-04T20:43:47Z

⌛ Testing commit d76daf5 with merge e086442...

frewsxcv · 2017-04-04T20:47:23Z

@bors retry

prioritizing rollup

bors · 2017-04-05T04:52:18Z

⌛ Testing commit d76daf5 with merge 3fe451b...

@eddyb

Handle extern functions and statics in save-analysis r? @eddyb

bors · 2017-04-05T06:00:08Z

💔 Test failed - status-travis

alexcrichton · 2017-04-05T17:21:09Z

@bors: retry * failed to compile openssl #40417

…

On Wed, Apr 5, 2017 at 12:00 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/218743858> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#40348 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95MZ4ulOpEe-CgbUJ6emHcKehx-pgks5rsy3qgaJpZM4MWX0n> .

bors · 2017-04-05T19:48:13Z

⌛ Testing commit d76daf5 with merge d97853a...

@eddyb

Handle extern functions and statics in save-analysis r? @eddyb

frewsxcv · 2017-04-05T19:50:51Z

@bors retry

prioritizing rollup which includes these changes

bors · 2017-04-05T20:06:05Z

⌛ Testing commit d76daf5 with merge 91ae22a...

@eddyb

Handle extern functions and statics in save-analysis r? @eddyb

bors · 2017-04-05T22:56:21Z

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 91ae22a to master...

nrc mentioned this pull request Mar 8, 2017
extern fns not linked? rust-dev-tools/rls-analysis#40
Closed

nrc assigned eddyb Mar 9, 2017

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 9, 2017
Rollup merge ofrust-lang#40348- nrc:save-extern-fn, r=eddyb
d042c51
Handle extern functions and statics in save-analysis r? @eddyb

arielb1 mentioned this pull request Mar 9, 2017
Rollup of 12 pull requests #40403
Closed

nrc force-pushed the save-extern-fn branch from 0aceb99 to 4cf22cbCompare March 15, 2017 21:43

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
Rollup merge ofrust-lang#40348- nrc:save-extern-fn, r=@eddyb
8bc39f8
Handle extern functions and statics in save-analysis r? @eddyb

frewsxcv mentioned this pull request Mar 18, 2017
Rollup of 20 pull requests #40643
Closed

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 18, 2017
Rollup merge ofrust-lang#40348- nrc:save-extern-fn, r=@eddyb
8e6afbf
Handle extern functions and statics in save-analysis r? @eddyb

arielb1 mentioned this pull request Mar 18, 2017
Rollup of 22 pull requests #40644
Closed

nrc force-pushed the save-extern-fn branch from 4cf22cb to 158079eCompare March 27, 2017 04:11

Nick Cameron added 3 commits April 4, 2017 15:56

save-analysis: only index path references once
4143d40

save-analysis: index extern blocks
ccdbb31

rebased
d76daf5

nrc force-pushed the save-extern-fn branch from 8f6b68c to d76daf5Compare April 4, 2017 04:08

bors added a commit that referenced this pull request Apr 5, 2017
Auto merge of#40348- nrc:save-extern-fn, r=eddyb
3fe451b
Handle extern functions and statics in save-analysis r? @eddyb

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017
Rollup merge ofrust-lang#40348- nrc:save-extern-fn, r=eddyb
580e8d7
Handle extern functions and statics in save-analysis r? @eddyb

frewsxcv mentioned this pull request Apr 5, 2017
Rollup of 9 pull requests #41093
Closed

bors added a commit that referenced this pull request Apr 5, 2017
Auto merge of#40348- nrc:save-extern-fn, r=eddyb
91ae22a
Handle extern functions and statics in save-analysis r? @eddyb

bors merged commit d76daf5 into rust-lang:masterApr 5, 2017

Uh oh!

Uh oh!

Conversation

nrc commented Mar 8, 2017

Uh oh!

eddyb commented Mar 8, 2017

Uh oh!

bors commented Mar 8, 2017

Uh oh!

bors commented Mar 9, 2017

Uh oh!

alexcrichton commented Mar 9, 2017

Uh oh!

arielb1 commented Mar 10, 2017

Uh oh!

arielb1 commented Mar 10, 2017

Uh oh!

nrc commented Mar 16, 2017

Uh oh!

bors commented Mar 16, 2017

Uh oh!

arielb1 commented Mar 19, 2017

Uh oh!

nrc commented Mar 19, 2017

Uh oh!

arielb1 commented Mar 19, 2017

Uh oh!

nrc commented Mar 19, 2017

Uh oh!

nrc commented Mar 27, 2017

Uh oh!

bors commented Mar 27, 2017

Uh oh!

bors commented Mar 27, 2017

Uh oh!

bors commented Mar 27, 2017

Uh oh!

nrc commented Mar 30, 2017

Uh oh!

bors commented Mar 30, 2017

Uh oh!

bors commented Mar 30, 2017

Uh oh!

nrc commented Apr 4, 2017

Uh oh!

bors commented Apr 4, 2017

Uh oh!

bors commented Apr 4, 2017

Uh oh!

frewsxcv commented Apr 4, 2017

Uh oh!

bors commented Apr 4, 2017

Uh oh!

frewsxcv commented Apr 4, 2017

Uh oh!

bors commented Apr 5, 2017

Uh oh!

bors commented Apr 5, 2017

Uh oh!

alexcrichton commented Apr 5, 2017 via email

Uh oh!

bors commented Apr 5, 2017

Uh oh!

frewsxcv commented Apr 5, 2017

Uh oh!

bors commented Apr 5, 2017

Uh oh!

bors commented Apr 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants