librustc: Implement explicit self for Add and Index; add a hack in the b... - #4057
Closed
pcwalton wants to merge 1 commit into
Closed
librustc: Implement explicit self for Add and Index; add a hack in the b...#4057pcwalton wants to merge 1 commit into
pcwalton wants to merge 1 commit into
Conversation
…e borrow checker to support this
Contributor
|
An egregious hack, but r+ |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Dec 8, 2024
Fix weak memory emulation to avoid generating behaviors that are forbidden under C++ 20
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
4057: Fix panic in split_imports assist r=matklad a=matklad The fix is admittedly quit literally just papering over. Long-term, I see two more principled approaches: * we switch to a fully tree-based impl, without parse . to_string step; with this approach, there shouldn't be any panics. The results might be nonsensical, but so was the original input. * we preserve the invariant that re-parsing constructed node is an identity, and make all the `make_xxx` method return an `Option`. closes rust-lang#4044 bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...orrow checker to support this
r? @nikomatsakis