Uh oh!
There was an error while loading. Please reload this page.
fix innacuracy in mir TerminatorKind::SwitchInt docs - #40576
Merged
Conversation
rust-highfive
commented
Mar 16, 2017
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
nrc
commented
Mar 17, 2017
Member
nagisa
commented
Mar 18, 2017
Member
r=me |
nikomatsakis
commented
Mar 20, 2017
Contributor
@bors r+ rollup |
bors
commented
Mar 20, 2017
Collaborator
📌 Commit e9c07cf has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 21, 2017
…po, r=nikomatsakis fix innacuracy in mir TerminatorKind::SwitchInt docs Each index of `values` corresponds to an index of `targets`, and `targets` additionally has a "default case" element at its end, so `targets.len() == values.len() + 1`, not the other way around. For example, [here](https://github.com/rust-lang/rust/blob/0aeb9c12979e6da753701a798d04105b6b1a8c28/src/librustc/mir/mod.rs#L549-L550) is a concrete instance of `SwitchInt` being constructed with `targets.len() == 2` and `values.len() == 1`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each index of
valuescorresponds to an index oftargets, andtargetsadditionally has a "default case" element at its end, sotargets.len() == values.len() + 1, not the other way around. For example, here is a concrete instance ofSwitchIntbeing constructed withtargets.len() == 2andvalues.len() == 1.