Skip to content

Fix invalid debug display for associated consts - #40587

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:rustdoc-const-display
Mar 20, 2017
Merged

Fix invalid debug display for associated consts#40587
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:rustdoc-const-display

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Mar 16, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#40568.

r? @rust-lang/docs

cc @SergioBenitez

@frewsxcv

frewsxcv commented Mar 16, 2017

Copy link
Copy Markdown
Contributor

@GuillaumeGomez Have a screenshot of the added test handy?

@GuillaumeGomez

GuillaumeGomez commented Mar 16, 2017

Copy link
Copy Markdown
MemberAuthor

Sure:

screen shot 2017-03-17 at 00 28 21

@sophiajt

sophiajt commented Mar 16, 2017

Copy link
Copy Markdown
Contributor

Out of curiosity, do we show both the struct and the fields today? I wasn't sure if that was something that was part of this PR.

@GuillaumeGomez

GuillaumeGomez commented Mar 16, 2017

Copy link
Copy Markdown
MemberAuthor

We do (take a look at the issue).

@sophiajt

sophiajt commented Mar 17, 2017

Copy link
Copy Markdown
Contributor

@GuillaumeGomez

From looking here https://api.rocket.rs/rocket/http/struct.ContentType.html it seems like your screenshot doesn't reflect what it will look like. Do you have one that's closer to the original in terms of the amount of content?

@GuillaumeGomez

GuillaumeGomez commented Mar 17, 2017

Copy link
Copy Markdown
MemberAuthor

@jonathandturner: I have absolutely no idea how to run a specific binary from cargo doc (I can't document Rocket without it).

@frewsxcv

frewsxcv commented Mar 18, 2017

Copy link
Copy Markdown
Contributor

This seems fine to me. Unless @jonathandturner has any other questions here, r=me

@sophiajt

sophiajt commented Mar 19, 2017

Copy link
Copy Markdown
Contributor

I'm good

@GuillaumeGomez

GuillaumeGomez commented Mar 19, 2017

Copy link
Copy Markdown
MemberAuthor

@bors: r=frewsxcv

@bors

bors commented Mar 19, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 5364acb has been approved by frewsxcv

@frewsxcvfrewsxcv mentioned this pull request Mar 19, 2017
Closed
@frewsxcvfrewsxcv mentioned this pull request Mar 20, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 20, 2017
@frewsxcv
Rollup merge ofrust-lang#40587- GuillaumeGomez:rustdoc-const-displa…
d49f869
…y, r=frewsxcv
Fix invalid debug display for associated consts
Fixesrust-lang#40568.
r? @rust-lang/docs
cc @SergioBenitez
bors added a commit that referenced this pull request Mar 20, 2017
@bors
Auto merge of#40659- frewsxcv:rollup, r=frewsxcv
244f893
Rollup of 9 pull requests
- Successful merges: #40241, #40281, #40398, #40521, #40532, #40554, #40566, #40581, #40587
- Failed merges:
@bors
bors merged commit 5364acb into rust-lang:masterMar 20, 2017
@GuillaumeGomez
GuillaumeGomez deleted the rustdoc-const-display branch March 20, 2017 12:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@frewsxcv@sophiajt@bors