Skip to content

Update the cargo submodule again - #40625

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:update-cargo-again
Mar 18, 2017
Merged

Update the cargo submodule again#40625
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:update-cargo-again

Conversation

@alexcrichton

@alexcrichtonalexcrichton commented Mar 18, 2017

Copy link
Copy Markdown
Member

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!

Closesrust-lang/cargo#3844

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

Copy link
Copy Markdown
MemberAuthor

cc @frewsxcv

no worries, just a reminder to be careful on those submodule updates!

Also infra's weekly reminder that a rust-highfive reminder of a submodule update would be useful...

@bors: r+ p=1000

(this is a nightly regression)

@bors

bors commented Mar 18, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9fb737b has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
…alexcrichton
Update the cargo submodule again
Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!
@frewsxcvfrewsxcv mentioned this pull request Mar 18, 2017
@frewsxcv

Copy link
Copy Markdown
Contributor

Ugghh sorry about this :(

@frewsxcv

Copy link
Copy Markdown
Contributor

Is it possible we could add a cargo version sanity check before publishing a new version?

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
…alexcrichton
Update the cargo submodule again
Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!
Closesrust-lang/cargo#3844
@frewsxcvfrewsxcv mentioned this pull request Mar 18, 2017
@bors

bors commented Mar 18, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fb737b with merge 5f8a4ec...

@bors

bors commented Mar 18, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@arielb1

Copy link
Copy Markdown
Contributor

@bors

bors commented Mar 18, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fb737b with merge 711a17c...

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
…alexcrichton
Update the cargo submodule again
Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!
Closesrust-lang/cargo#3844
@frewsxcvfrewsxcv mentioned this pull request Mar 18, 2017
@frewsxcv

Copy link
Copy Markdown
Contributor

@bors retry

prioritizing rollup which has this

@bors

bors commented Mar 18, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fb737b with merge 4853584...

bors added a commit that referenced this pull request Mar 18, 2017
Update the cargo submodule again
Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!
Closesrust-lang/cargo#3844
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
…alexcrichton
Update the cargo submodule again
Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!
Closesrust-lang/cargo#3844
@frewsxcvfrewsxcv mentioned this pull request Mar 18, 2017
@bors

bors commented Mar 18, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4853584 to master...

@bors
bors merged commit 9fb737b into rust-lang:masterMar 18, 2017
@alexcrichton
alexcrichton deleted the update-cargo-again branch April 4, 2017 23:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@alexcrichton@rust-highfive@bors@frewsxcv@arielb1@aturon