Uh oh!
There was an error while loading. Please reload this page.
Convert MIR BasicBlocks to ExtendedBasicBlocks - #40700
Closed
Mark-Simulacrum wants to merge 19 commits into
Closed
Conversation
Mark-Simulacrum
commented
Mar 21, 2017
MemberAuthor
r? @eddyb |
rust-highfive
commented
Mar 21, 2017
Contributor
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Mar 21, 2017
Collaborator
☔ The latest upstream changes (presumably #40693) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
commented
Mar 25, 2017
Collaborator
☔ The latest upstream changes (presumably #40806) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrumforce-pushed
the
extbb-2
branch
3 times, most recently
from
March 25, 2017 17:22
1106eff to
1448131CompareThis introduces no functional changes, but is in preparation for adding extended basic blocks to MIR.
* Updates Drop, Assert, and Call TerminatorKinds to do this. * Changes various code in these terminators to have more uniform completions and replaced non-end-of-block llblock and funclet_br with the code that they'd execute.
This removes the unreachable_block cache, since we no longer utilize it.
This reverts commit 8cee04a. It turns out that DropElaboration may need the CallGuards pass, even if trans doesn't.
bors
commented
Mar 30, 2017
Collaborator
☔ The latest upstream changes (presumably #40597) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrumforce-pushed
the
extbb-2
branch
2 times, most recently
from
April 8, 2017 16:18
3f23d75 to
15d5bdeCompareMark-Simulacrum
commented
Apr 14, 2017
MemberAuthor
I'm going to close this out for now since it's relatively blocked on me finding a good chunk of time to work on uninterrupted, but if anyone wants to steal my branch, feel free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still a work in progress, will write up more detailed summary later, but see #39685.