Emit proper lifetime start intrinsics for personality slots by dotdash · Pull Request #40908 · rust-lang/rust

dotdash · 2017-03-29T18:46:44Z

We currently only emit a single call to the lifetime start intrinsic
for the personality slot alloca. This happens because we create that
call at the time that we create the alloca, instead of creating it each
time we start using it. Because LLVM usually removes the alloca before
the lifetime intrinsics are even considered, this didn't cause any
problems yet, but we should fix this anyway.

We currently only emit a single call to the lifetime start intrinsic for the personality slot alloca. This happens because we create that call at the time that we create the alloca, instead of creating it each time we start using it. Because LLVM usually removes the alloca before the lifetime intrinsics are even considered, this didn't cause any problems yet, but we should fix this anyway.

rust-highfive · 2017-03-29T18:46:46Z

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

arielb1 · 2017-03-30T11:20:10Z

@bors r+

bors · 2017-03-30T11:20:11Z

📌 Commit 1eaa113 has been approved by arielb1

bors · 2017-03-31T14:09:59Z

⌛ Testing commit 1eaa113 with merge d425d23...

bors · 2017-03-31T15:22:54Z

💔 Test failed - status-appveyor

Exception handling on MSVC targets doesn't use personality slots.

dotdash · 2017-03-31T18:11:15Z

Disabled the test on MSVC which doesn't use personality slots.

arielb1 · 2017-03-31T21:59:15Z

@bors r+

bors · 2017-03-31T21:59:16Z

📌 Commit 0ba7da3 has been approved by arielb1

bors · 2017-04-01T12:46:16Z

⌛ Testing commit 0ba7da3 with merge 773d1ea...

bors · 2017-04-01T13:10:08Z

💔 Test failed - status-travis

alexcrichton · 2017-04-01T13:19:36Z

@bors: retry * sccache failure - #40240

…

On Sat, Apr 1, 2017 at 7:10 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/217513825> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#40908 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95FJhINx6O8E3D_PbfyXkO8UdqFciks5rrkyxgaJpZM4MtZcU> .

Emit proper lifetime start intrinsics for personality slots We currently only emit a single call to the lifetime start intrinsic for the personality slot alloca. This happens because we create that call at the time that we create the alloca, instead of creating it each time we start using it. Because LLVM usually removes the alloca before the lifetime intrinsics are even considered, this didn't cause any problems yet, but we should fix this anyway.

bors · 2017-04-01T21:08:16Z

⌛ Testing commit 0ba7da3 with merge 90e9d92...

bors · 2017-04-01T23:25:28Z

💔 Test failed - status-appveyor

alexcrichton · 2017-04-02T02:00:36Z

@bors: retry

Spurious failure removing std.dll during tests on MSVC #41006 weird spurious issue removing a dll?

bors · 2017-04-02T05:06:13Z

⌛ Testing commit 0ba7da3 with merge c684503...

bors · 2017-04-02T06:57:21Z

💔 Test failed - status-appveyor

dotdash · 2017-04-03T11:42:42Z

Is that a spurious error? That build completed in the previous run.

arielb1 · 2017-04-03T12:03:45Z

Let's see

@bors retry

arielb1 · 2017-04-03T12:04:49Z

Failure is:

	test
running `C:\projects\rust\build\ct\cargo\target\debug\cargo test -v`
thread 'test_release_ignore_panic' panicked at '
Expected: execs
but: exited with exit code: 3221225477
--- stdout
--- stderr
Compiling a v0.0.1 (file:///C:/projects/rust/build/ct/cargo/target/cit/t53/foo/a)
Running `rustc --crate-name a a\src\lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=0844ace4ff28f02a -C extra-filename=-0844ace4ff28f02a --out-dir C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\debug\deps -L dependency=C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\debug\deps`
Compiling foo v0.0.1 (file:///C:/projects/rust/build/ct/cargo/target/cit/t53/foo)
Running `rustc --crate-name foo src\lib.rs --emit=dep-info,link -C debuginfo=2 --test -C metadata=0a91976aa53e67d4 -C extra-filename=-0a91976aa53e67d4 --out-dir C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\debug\deps -L dependency=C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\debug\deps --extern a=C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\debug\deps\liba-0844ace4ff28f02a.rlib`
Running `rustc --crate-name foo src\lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=350a25faded805d4 -C extra-filename=-350a25faded805d4 --out-dir C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\debug\deps -L dependency=C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\debug\deps --extern a=C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\debug\deps\liba-0844ace4ff28f02a.rlib`
Finished dev [unoptimized + debuginfo] target(s) in 0.64 secs
Running `C:\projects\rust\build\ct\cargo\target\cit\t53\foo\target\debug\deps\foo-0a91976aa53e67d4.exe`
error: test failed
', C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\hamcrest-0.1.1\src\core.rs:31
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
test_release_ignore_panic
test result: FAILED. 61 passed; 1 failed; 0 ignored; 0 measured

bors · 2017-04-03T19:58:19Z

⌛ Testing commit 0ba7da3 with merge 9a388b8...

bors · 2017-04-03T20:10:08Z

💔 Test failed - status-travis

alexcrichton · 2017-04-03T22:16:01Z

@bors: retry * centos network issues #40474

…

On Mon, Apr 3, 2017 at 2:10 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/218210808> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#40908 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95PoSTnLKtKNXOSTR3D5BkDSRA_WAks5rsVIigaJpZM4MtZcU> .

Emit proper lifetime start intrinsics for personality slots We currently only emit a single call to the lifetime start intrinsic for the personality slot alloca. This happens because we create that call at the time that we create the alloca, instead of creating it each time we start using it. Because LLVM usually removes the alloca before the lifetime intrinsics are even considered, this didn't cause any problems yet, but we should fix this anyway.

Rollup of 5 pull requests - Successful merges: #40908, #41011, #41026, #41037, #41050 - Failed merges:

bors · 2017-04-06T08:34:55Z

⌛ Testing commit 0ba7da3 with merge e5e9275...

rust-highfive assigned arielb1 Mar 29, 2017

Ignore tests for the personality slot lifetimes on MSVC
0ba7da3
Exception handling on MSVC targets doesn't use personality slots.

frewsxcv mentioned this pull request Apr 1, 2017
Rollup of 4 pull requests #40986
Closed

frewsxcv mentioned this pull request Apr 1, 2017
Rollup of 5 pull requests #41002
Closed

frewsxcv mentioned this pull request Apr 6, 2017
Rollup of 8 pull requests #41100
Closed

frewsxcv mentioned this pull request Apr 6, 2017
Rollup of 7 pull requests #41101
Closed

frewsxcv mentioned this pull request Apr 6, 2017
Rollup of 5 pull requests #41102
Merged

bors added a commit that referenced this pull request Apr 6, 2017
Auto merge of#41102- frewsxcv:rollup, r=frewsxcv
e5e9275
Rollup of 5 pull requests - Successful merges: #40908, #41011, #41026, #41037, #41050 - Failed merges:

bors merged commit 0ba7da3 into rust-lang:masterApr 6, 2017

dotdash deleted the pers_lt branch January 31, 2018 11:34

Uh oh!

Uh oh!

Conversation

dotdash commented Mar 29, 2017

Uh oh!

rust-highfive commented Mar 29, 2017

Uh oh!

arielb1 commented Mar 30, 2017

Uh oh!

bors commented Mar 30, 2017

Uh oh!

bors commented Mar 31, 2017

Uh oh!

bors commented Mar 31, 2017

Uh oh!

dotdash commented Mar 31, 2017

Uh oh!

arielb1 commented Mar 31, 2017

Uh oh!

bors commented Mar 31, 2017

Uh oh!

bors commented Apr 1, 2017

Uh oh!

bors commented Apr 1, 2017

Uh oh!

alexcrichton commented Apr 1, 2017 via email

Uh oh!

bors commented Apr 1, 2017

Uh oh!

bors commented Apr 1, 2017

Uh oh!

alexcrichton commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

dotdash commented Apr 3, 2017

Uh oh!

arielb1 commented Apr 3, 2017

Uh oh!

arielb1 commented Apr 3, 2017

Uh oh!

bors commented Apr 3, 2017

Uh oh!

bors commented Apr 3, 2017

Uh oh!

alexcrichton commented Apr 3, 2017 via email

Uh oh!

bors commented Apr 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants