Skip to content

Add a note about overflow for fetch_add/fetch_sub - #40927

Merged
bors merged 2 commits into
masterfrom
unknown repository
Apr 6, 2017
Merged

Add a note about overflow for fetch_add/fetch_sub#40927
bors merged 2 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 30, 2017

Copy link
Copy Markdown

@ghost

Copy link
Copy Markdown
Author

I also changed some other docs:

  • Instead of using both "previous" and "old", use "previous" consistently.
  • Switch from imperative "Add" to "Adds".
  • Add quotes where necessary and mirror the docs for atomic integers with the docs for AtomicBool.

@steveklabniksteveklabnik added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 31, 2017
@steveklabnik

steveklabnik commented Mar 31, 2017

Copy link
Copy Markdown
Contributor

The doc changes look good to me. However, let's

@rfcbot : fcp merge

for libs, to make sure this is the behavior they want specc'd

Oh wait, that doesn't work because I'm not on @rust-lang/libs

@ghost

Copy link
Copy Markdown
Author

cc @alexcrichton
cc @Amanieu

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

Yeah these are the intended semantics

@bors

bors commented Apr 1, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 2946c41 has been approved by alexcrichton

@frewsxcvfrewsxcv mentioned this pull request Apr 1, 2017
@frewsxcvfrewsxcv mentioned this pull request Apr 1, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017
… r=alexcrichton
Add a note about overflow for fetch_add/fetch_sub
Fixesrust-lang#40916
r? @steveklabnik
@frewsxcvfrewsxcv mentioned this pull request Apr 2, 2017
@bors

bors commented Apr 2, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2946c41 with merge f6cc11b...

bors added a commit that referenced this pull request Apr 2, 2017
…hton
Add a note about overflow for fetch_add/fetch_sub
Fixes#40916Fixes#34618
r? @steveklabnik
@bors

bors commented Apr 2, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Apr 2, 2017 via email

Copy link
Copy Markdown
Member

@bors

bors commented Apr 3, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2946c41 with merge a2c3aa7...

@bors

bors commented Apr 3, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: retry

something went wrong and the job took too long

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
… r=alexcrichton
Add a note about overflow for fetch_add/fetch_sub
Fixesrust-lang#40916Fixesrust-lang#34618
r? @steveklabnik
@frewsxcvfrewsxcv mentioned this pull request Apr 3, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
… r=alexcrichton
Add a note about overflow for fetch_add/fetch_sub
Fixesrust-lang#40916Fixesrust-lang#34618
r? @steveklabnik
@frewsxcvfrewsxcv mentioned this pull request Apr 3, 2017
@bors

bors commented Apr 3, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2946c41 with merge 93636b1...

@bors

bors commented Apr 3, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Apr 3, 2017 via email

Copy link
Copy Markdown
Member

@arielb1arielb1 mentioned this pull request Apr 5, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 5, 2017
… r=alexcrichton
Add a note about overflow for fetch_add/fetch_sub
Fixesrust-lang#40916Fixesrust-lang#34618
r? @steveklabnik
@arielb1arielb1 mentioned this pull request Apr 5, 2017
bors added a commit that referenced this pull request Apr 6, 2017
Rollup of 12 pull requests
- Successful merges: #40479, #40561, #40709, #40815, #40909, #40927, #40943, #41015, #41028, #41052, #41054, #41065
- Failed merges:
@bors
bors merged commit 2946c41 into rust-lang:masterApr 6, 2017
@ghost
ghost deleted the docs-atomic-overflow-note branch April 6, 2017 08:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@steveklabnik@alexcrichton@bors