Uh oh!
There was an error while loading. Please reload this page.
Modify str Structs descriptions - #40935
Merged
Merged
Conversation
rust-highfive
commented
Mar 30, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Original headline of SplitWhitespace's description is more descriptive as to what it contains and iterates over.
steveklabnik
suggested changes
Mar 30, 2017
steveklabnik
left a comment
Contributor
There was a problem hiding this comment.
one tiny thing and then this is good to go!
| /// For use with the `std::iter` module. | ||
| /// [`u16`]: ../../std/primitive.u16.html | ||
| /// | ||
| /// This struct is created by the [`encode_utf16()`] method on [`str`]. |
Contributor
There was a problem hiding this comment.
we don't include the ()s when referencing methods; could you change that everywhere please?
alexcrichton
commented
Mar 31, 2017
Member
steveklabnik
approved these changes
Mar 31, 2017
Contributor
@bors: r+ rollup Thanks a ton! |
bors
commented
Mar 31, 2017
Collaborator
📌 Commit 3b39621 has been approved by |
bors
commented
Mar 31, 2017
Collaborator
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
Mar 31, 2017
Collaborator
📌 Commit 3b39621 has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 31, 2017
…r=steveklabnik Modify str Structs descriptions References rust-lang#29375. Modified descriptions of multiple structs to be more in line with structs found under [`std::iter`](https://doc.rust-lang.org/std/iter/#structs), such as [`Chain`](https://doc.rust-lang.org/std/iter/struct.Chain.html) and [`Enumerate`](https://doc.rust-lang.org/std/iter/struct.Enumerate.html)
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 31, 2017
…r=steveklabnik Modify str Structs descriptions References rust-lang#29375. Modified descriptions of multiple structs to be more in line with structs found under [`std::iter`](https://doc.rust-lang.org/std/iter/#structs), such as [`Chain`](https://doc.rust-lang.org/std/iter/struct.Chain.html) and [`Enumerate`](https://doc.rust-lang.org/std/iter/struct.Enumerate.html)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #29375. Modified descriptions of multiple structs to be more in line with structs found under
std::iter, such asChainandEnumerate