Uh oh!
There was an error while loading. Please reload this page.
[beta] Beta next - #41016
Merged
Merged
Conversation
rust-highfive
commented
Apr 2, 2017
Contributor
|
When the Range expression is the root of a constant, its node-id is used for the def-id of the body, so it has to be preserved in the AST -> HIR lowering. Fixesrust-lang#40749.
LLVM has a bug - PR32488 - where it fails to deduplicate allocas in some circumstances. The function `start_new_block` has allocas totalling 1216 bytes, and when LLVM inlines several copies of that function into the recursive function `expr::into`, that function's stack space usage goes into tens of kiBs, causing stack overflows. Mark `start_new_block` as inline(never) to keep it from being inlined, getting stack usage under control. Fixesrust-lang#40493. Fixesrust-lang#40573.
alexcrichton
commented
Apr 3, 2017
Member
@bors: r+ p=10 |
bors
commented
Apr 3, 2017
Collaborator
📌 Commit df61f9d has been approved by |
bors
commented
Apr 3, 2017
Collaborator
⌛ Testing commit df61f9d with merge b26aa7a... |
bors
commented
Apr 3, 2017
Collaborator
💔 Test failed - status-appveyor |
arielb1
commented
Apr 3, 2017
ContributorAuthor
@bors retry |
bors
commented
Apr 3, 2017
Collaborator
⌛ Testing commit df61f9d with merge 1ae72f9... |
bors
commented
Apr 3, 2017
Collaborator
💔 Test failed - status-travis |
Looks like the last version was built with mio 0.6.5 which now has known bugs against it. This build includes mio 0.6.6
arielb1
commented
Apr 3, 2017
ContributorAuthor
Updated sccache to newest (#40809) so we can have more than 10% build success probability. |
alexcrichton
commented
Apr 3, 2017
Member
@bors: r+ |
bors
commented
Apr 3, 2017
Collaborator
📌 Commit ab18aae has been approved by |
bors
commented
Apr 3, 2017
Collaborator
⌛ Testing commit ab18aae with merge 891e69c... |
bors
commented
Apr 3, 2017
Collaborator
💔 Test failed - status-travis |
arielb1
commented
Apr 3, 2017
ContributorAuthor
Network failure @bors retry |
bors
commented
Apr 3, 2017
Collaborator
⌛ Testing commit ab18aae with merge 6d2633d... |
bors
commented
Apr 3, 2017
Collaborator
💔 Test failed - status-travis |
frewsxcv
commented
Apr 3, 2017
Contributor
bors
commented
Apr 3, 2017
Collaborator
⌛ Testing commit ab18aae with merge ae0d1d0... |
frewsxcv
commented
Apr 3, 2017
Contributor
@bors retry |
bors
commented
Apr 3, 2017
Collaborator
⌛ Testing commit ab18aae with merge dbd6473... |
frewsxcv
commented
Apr 3, 2017
Contributor
@bors retry |
bors
commented
Apr 3, 2017
Collaborator
⌛ Testing commit ab18aae with merge 1d32d91... |
frewsxcv
commented
Apr 3, 2017
Contributor
@bors retry |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @brson