Rollup of 8 pull requests by frewsxcv · Pull Request #41018 · rust-lang/rust

frewsxcv · 2017-04-02T14:10:57Z

Successful merges: fixed some clippy warnings in libcollections #40541, rustc: Stabilize the #![windows_subsystem] attribute #40870, Improve some docs for VecDeque #40949, API Docs: ascii #40988, Added links to from_utf8 methods in Utf8Error #40992, Added links to types in from_utf8 description #40997, Improve documentation for std::fs::DirBuilder #41007, std::thread docs: fix link to current() #41014
Failed merges:

* Change `utf8` variable names to `non_ascii` to be more clear, since ASCII and UTF-8 are compatible. * Fix `EscapeDefault` struct description to follow the typical iterator method format with a link to the generating function. * Add more `escape_default` examples to cover every case mentioned in the function description itself.

This commit stabilizes the `#![windows_subsystem]` attribute which is a conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This is useful for creating applications as well as console programs. Closesrust-lang#37499

rust-highfive · 2017-04-02T14:11:03Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

frewsxcv · 2017-04-02T14:11:15Z

@bors r+ p=10

bors · 2017-04-02T14:11:16Z

📌 Commit 16247f1 has been approved by frewsxcv

bors · 2017-04-02T16:30:45Z

⌛ Testing commit 16247f1 with merge 048931c...

bors · 2017-04-02T17:58:06Z

💔 Test failed - status-travis

frewsxcv · 2017-04-02T18:21:56Z

@bors retry


[01:17:38] warning: spurious network error (2 tries remaining): [28] Timeout was reached (Connection timed out after 30001 milliseconds)
[01:18:08] warning: spurious network error (1 tries remaining): [28] Timeout was reached (Connection timed out after 30010 milliseconds)
[01:18:38] error: unable to get packages from source

bors · 2017-04-03T00:15:55Z

⌛ Testing commit 16247f1 with merge 8603389...

bors · 2017-04-03T01:26:06Z

💔 Test failed - status-travis

frewsxcv · 2017-04-03T03:49:50Z

@bors retry

bors · 2017-04-03T06:15:34Z

⌛ Testing commit 16247f1 with merge 1404667...

bors · 2017-04-03T07:58:10Z

💔 Test failed - status-appveyor

arielb1 · 2017-04-03T08:00:21Z

Testing libstd stage2 (i686-pc-windows-gnu -> i686-pc-windows-gnu)
Compiling cmake v0.1.22
Compiling rand v0.0.0 (file:///C:/projects/rust/src/librand)
Compiling rustc_asan v0.0.0 (file:///C:/projects/rust/src/librustc_asan)
Compiling alloc v0.0.0 (file:///C:/projects/rust/src/liballoc)
Compiling core v0.0.0 (file:///C:/projects/rust/src/libcore)
Compiling collections v0.0.0 (file:///C:/projects/rust/src/libcollections)
error: linking with `gcc` failed: exit code: 1
|
= note: "gcc" "-Wl,--enable-long-section-names" "-fno-use-linker-plugin" "-Wl,--nxcompat" "-nostdlib" "-Wl,--large-address-aware" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\crt2.o" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsbegin.o" "-L" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\i686-pc-windows-gnu\\release\\deps\\collectionstest-cf7d8872f6b0686a.0.o" "-o" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\i686-pc-windows-gnu\\release\\deps\\collectionstest-cf7d8872f6b0686a.exe" "-Wl,--gc-sections" "-nodefaultlibs" "-L" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\i686-pc-windows-gnu\\release\\deps" "-L" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1-std\\release\\deps" "-L" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-Wl,-Bstatic" "-Wl,-Bdynamic" "-L" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-l" "test-51dd1e12bb8fc6c0" "-L" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-l" "term-9bb4a9959ced7ebc" "-L" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-l" "getopts-83c65310844a796d" "-L" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-l" "std-4d6881ec6132b951" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\libcompiler_builtins-7ac5a34e9b48514f.rlib" "-l" "kernel32" "-l" "advapi32" "-l" "ws2_32" "-l" "userenv" "-l" "shell32" "-l" "gcc_eh" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-luser32" "-lkernel32" "C:\\projects\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsend.o"
= note: collect2.exe: error: ld returned 5 exit status

…ystem, r=aturon rustc: Stabilize the `#![windows_subsystem]` attribute This commit stabilizes the `#![windows_subsystem]` attribute which is a conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This is useful for creating applications as well as console programs. Closesrust-lang#37499

@GuillaumeGomez

Improve some docs for VecDeque r? @GuillaumeGomez

@steveklabnik

API Docs: ascii Add/update docs for the `ascii` module per rust-lang#29341. r? @steveklabnik

…xcrichton Added links to from_utf8 methods in Utf8Error Referencing rust-lang#29375. Linked the `from_utf8` methods for both `String` and `str` in the description. Also linked the `u8` to its documentation

…teveklabnik Added links to types in from_utf8 description References rust-lang#29375. Link to types mentioned in the documentation for `from_utf8` (`str`, `&[u8`], etc). Paragraphs were reformatted to keep any one line from being excessively long, but are otherwise unchanged.

@steveklabnik

…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik

Improve documentation for `std::fs::DirBuilder`

std::thread docs: fix link to current()

Stjepan Glavinaand others added 13 commits March 31, 2017 17:12

Improve some docs for VecDeque
d7b3f05

Change wording for push_front
1e2a61d

Added links to from_utf8 methods in Utf8Error
5198072

Add more std::ascii module-level docs.
a5d775d

Added links to types in from_utf8 description
364241c

Improve docs of core::option::IntoIter
128a313

Improve docs of core::option::IterMut
029ace4

Improve docs of core::option::Iter
c414628

Minor changes to core::option docs
4c9f8ae

Improve documentation for std::fs::DirBuilder
ff4febf

std::thread docs: fix link to current()
509ef4c

rust-highfive assigned aturon Apr 2, 2017

Rollup merge ofrust-lang#40949- stjepang:fix-vecdeque-docs, r=frewsxcv
f7358ec
Improve some docs for VecDeque r? @GuillaumeGomez

frewsxcv force-pushed the rollup branch from 16247f1 to 5309a3eCompare April 3, 2017 12:57

frewsxcv added 6 commits April 3, 2017 08:57

Rollup merge ofrust-lang#40988- eugene-bulkin:ascii-docs, r=frewsxcv
a81aaf4
API Docs: ascii Add/update docs for the `ascii` module per rust-lang#29341. r? @steveklabnik

Rollup merge ofrust-lang#40992- donniebishop:utf8err_linking, r=ale…
b51c991
…xcrichton Added links to from_utf8 methods in Utf8Error Referencing rust-lang#29375. Linked the `from_utf8` methods for both `String` and `str` in the description. Also linked the `u8` to its documentation

Rollup merge ofrust-lang#40999- irfanhudda:improve-option-docs, r=s…
7a86857
…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik

Rollup merge ofrust-lang#41007- pgerber:dir_builder, r=frewsxcv
2a75d94
Improve documentation for `std::fs::DirBuilder`

Rollup merge ofrust-lang#41014- SimonSapin:patch-6, r=frewsxcv
e7bc3d7
std::thread docs: fix link to current()

frewsxcv closed this Apr 3, 2017

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Navigation Menu

Uh oh!

Uh oh!

Rollup of 8 pull requests - #41018

Rollup of 8 pull requests#41018
frewsxcv wants to merge 21 commits into
rust-lang:masterfrom
frewsxcv:rollup

frewsxcv commented Apr 2, 2017

Uh oh!

rust-highfive commented Apr 2, 2017

Uh oh!

frewsxcv commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

frewsxcv commented Apr 2, 2017

Uh oh!

bors commented Apr 3, 2017

Uh oh!

bors commented Apr 3, 2017

Uh oh!

frewsxcv commented Apr 3, 2017

Uh oh!

bors commented Apr 3, 2017

Uh oh!

bors commented Apr 3, 2017

Uh oh!

arielb1 commented Apr 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Uh oh!

Conversation

frewsxcv commented Apr 2, 2017

Uh oh!

rust-highfive commented Apr 2, 2017

Uh oh!

frewsxcv commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

bors commented Apr 2, 2017

Uh oh!

frewsxcv commented Apr 2, 2017

Uh oh!

bors commented Apr 3, 2017

Uh oh!

bors commented Apr 3, 2017

Uh oh!

frewsxcv commented Apr 3, 2017

Uh oh!

bors commented Apr 3, 2017

Uh oh!

bors commented Apr 3, 2017

Uh oh!

arielb1 commented Apr 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants