Skip to content

Rollup of 5 pull requests - #41226

Closed
frewsxcv wants to merge 15 commits into
rust-lang:masterfrom
frewsxcv:rollup
Closed

Rollup of 5 pull requests#41226
frewsxcv wants to merge 15 commits into
rust-lang:masterfrom
frewsxcv:rollup

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Apr 11, 2017

Copy link
Copy Markdown
Contributor

nagisaand others added 15 commits April 9, 2017 18:50
@nagisa
Implement Manually Drop
f6e5661
@nagisa
Move away from the ad-hoc NoDrop unions
3871312
@nagisa
Replace the forget intrinsic with ManuallyDrop
c94b3f1
less intrinsics = better life
@nagisa
into_inner to associated function
4863455
@nagisa
Fix test failures
c337b99
@GuillaumeGomez
Fix block code headers parsing
d4aecf5
@brson
Convert HashMap to BTree in build-manifest
1c3f34d
Nathaniel Ringo
Fixes incorrect formatting in array's documentation.
b9d662a
@aidanhs
Make sccache a bit quieter
f297767
@GuillaumeGomez
Remove strings fulfilled with whitespaces in code block headers
143f7be
@frewsxcv
Rollup merge ofrust-lang#40559- nagisa:manually-drop, r=alexcrichton
4fa2226
Implement Manually Drop
As the RFC has been from approx a week in FCP without any major comments, I’m taking the opportunity to submit the PR early.
@frewsxcv
Rollup merge ofrust-lang#41173- GuillaumeGomez:fix-rustdoc-code-blo…
cfcdf08
…ck-parsing, r=steveklabnik
Fix block code headers parsing
Fixesrust-lang#41167.
r? @rust-lang/docs
@frewsxcv
Rollup merge ofrust-lang#41202- brson:btree, r=nikomatsakis
04425a9
Convert HashMap to BTree in build-manifest
This is just for my peace of mind since it's important the output of this program be deterministic.
@frewsxcv
Rollup merge ofrust-lang#41204- remexre:master, r=steveklabnik
3f1c21e
Fixes incorrect formatting in array's documentation.
Changes
- [`Clone`][clone] (only if `T: [Copy][copy]`)
to
- [`Clone`][clone] (only if `T: `[`Copy`](copy))
r? @steveklabnik
@frewsxcv
Rollup merge ofrust-lang#41209- aidanhs:aphs-quiet-sccache, r=alexc…
5bda299
…richton
Make sccache a bit quieter
...and remove the single mention of `SCCACHE_LOG_LEVEL` that would only take effect on Docker (i.e. Linux) builds since it had no effect anyway (because [`RUST_LOG` takes priority](https://github.com/mozilla/sccache/blob/ec10cdb2ddeb3dde9891bea1fa095e504a60a28a/src/main.rs#L124-L128)).
r? @frewsxcv
@rust-highfive

rust-highfive commented Apr 11, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv

frewsxcv commented Apr 11, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r+ p=10

@bors

bors commented Apr 11, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 5bda299 has been approved by frewsxcv

@bors

bors commented Apr 11, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5bda299 with merge 31f7ff3...

@bors

bors commented Apr 11, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@frewsxcv
frewsxcv deleted the rollup branch April 11, 2017 20:21
@CentrilCentril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

rollupA PR which is a rollup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@frewsxcv@rust-highfive@bors@alexcrichton@Centril@nagisa@GuillaumeGomez@brson@aidanhs