Skip to content

[beta] Rollup of 2 pull requests - #41283

Merged
bors merged 4 commits into
rust-lang:betafrom
frewsxcv:rollup
Apr 14, 2017
Merged

[beta] Rollup of 2 pull requests#41283
bors merged 4 commits into
rust-lang:betafrom
frewsxcv:rollup

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive

rust-highfive commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

warningWarningwarning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@frewsxcv

frewsxcv commented Apr 13, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r+ p=10

@bors

bors commented Apr 13, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 3303f0d has been approved by frewsxcv

@frewsxcvfrewsxcv changed the title Rollup of 2 pull requests[beta] Rollup of 2 pull requestsApr 13, 2017
@bors

bors commented Apr 13, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3303f0d with merge a260f22...

bors added a commit that referenced this pull request Apr 13, 2017
@bors
Auto merge of#41283- frewsxcv:rollup, r=frewsxcv
a260f22
[beta] Rollup of 2 pull requests
- Successful merges: #41233, #41274
- Failed merges:
@bors

bors commented Apr 14, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing a260f22 to beta...

@bors
bors merged commit 3303f0d into rust-lang:betaApr 14, 2017
@borsbors mentioned this pull request Apr 14, 2017
Merged
@CentrilCentril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

rollupA PR which is a rollup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@frewsxcv@rust-highfive@bors@nikomatsakis@Centril@TimNN