Add top level sections to the Unstable Book. by frewsxcv · Pull Request #41295 · rust-lang/rust

frewsxcv · 2017-04-14T02:57:14Z

Prior to this commit, the contents of the Unstable Book were assumed to
be unstable features. This commit moves features into 'language features'
or 'library features' subsections. It also moves the 'linker_flavor'
compiler flag into a new 'Compiler Flags' subsection.

Even though it was helpful, I removed the tidy check that
cross-references the SUMMARY.md links with the Unstable Book directory
contents just because it would be difficult to maintain.

Relevant PR: #41142.

rust-highfive · 2017-04-14T02:57:20Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Mark-Simulacrum · 2017-04-14T04:57:27Z

Looks like a Cargo.lock file here needs to be updated presumably because of this change.

steveklabnik · 2017-04-14T15:16:40Z

While we're doing this, should language features vs library features also happen?

frewsxcv · 2017-04-14T15:32:42Z

While we're doing this, should language features vs library features also happen?

Yeah, I can do that.

bors · 2017-04-15T01:57:58Z

☔ The latest upstream changes (presumably #41305) made this pull request unmergeable. Please resolve the merge conflicts.

frewsxcv · 2017-04-15T19:03:31Z

@steveklabnik How does this look?

frewsxcv · 2017-04-16T00:13:46Z

If anyone has any idea what's going on with the linkchecker here, please let me know

frewsxcv · 2017-04-16T16:06:01Z

I fixed most of the tidy lint issues, I had to disable linkchecker for the Unstable Book (for now), since I'm using a subdirectory which mdbook uses <base> for which linkchecker doesn't support.

The remaining issues are here:

book/compiler-plugins.html:32: broken link - unstable-book/plugin.html
book/first-edition/print.html:8645: broken link - unstable-book/intrinsics.html
book/first-edition/print.html:13986: broken link - unstable-book/lang-items.html
book/first-edition/unsafe.html:188: broken link - unstable-book/intrinsics.html
book/first-edition/using-rust-without-the-standard-library.html:79: broken link - unstable-book/lang-items.html
reference/attributes.html:392: broken link - unstable-book/plugin.html
reference/macros.html:80: broken link - unstable-book/plugin.html
reference/print.html:559: broken link - unstable-book/plugin.html
reference/print.html:2193: broken link - unstable-book/plugin.html

These require changes upstream to the book and reference. What's the recommended approach? Set up redirects for everything?

bors · 2017-04-16T22:27:12Z

☔ The latest upstream changes (presumably #40409) made this pull request unmergeable. Please resolve the merge conflicts.

steveklabnik · 2017-04-17T15:17:16Z

These require changes upstream to the book and reference. What's the recommended approach? Set up redirects for everything?

We say this PR is good to go, then you update the submodules in this PR and ship it together. let's do that

frewsxcv · 2017-04-17T16:21:31Z

We say this PR is good to go

Sooooo is this PR good to go? ;) I can take care of the merge conflict, though they're going to keep popping up until this (and the book/reference PRs) gets shipped

steveklabnik · 2017-04-17T16:41:49Z

Yes, conceptually this PR is good to go; as long as you can take care of all of it within this week (due to beta branching), then let's do it.

Fixesrust-lang/rust#41295.

rust-lang/rust#41295

Prior to this commit, the contents of the Unstable Book were assumed to be unstable features. This commit moves features into 'language features' or 'library features' subsections. It also moves the 'linker_flavor' compiler flag into a new 'Compiler Flags' subsection. Even though it was helpful, I removed the tidy check that cross-references the SUMMARY.md links with the Unstable Book directory contents just because it would be difficult to maintain. Relevant PR: rust-lang#41142.

frewsxcv · 2017-04-19T01:26:32Z

@bors r=steveklabnik

bors · 2017-04-19T01:26:32Z

📌 Commit bf202c8 has been approved by steveklabnik

…teveklabnik Add top level sections to the Unstable Book. Prior to this commit, the contents of the Unstable Book were assumed to be unstable features. This commit moves features into 'language features' or 'library features' subsections. It also moves the 'linker_flavor' compiler flag into a new 'Compiler Flags' subsection. Even though it was helpful, I removed the tidy check that cross-references the SUMMARY.md links with the Unstable Book directory contents just because it would be difficult to maintain. Relevant PR: rust-lang#41142.

eddyb · 2017-04-19T08:27:10Z

@bors r- Likely responsible for #41387 (comment)

frewsxcv · 2017-04-19T17:11:39Z

@bors r=steveklabnik

fixed with 2e2a670

bors · 2017-04-19T17:11:40Z

📌 Commit 2e2a670 has been approved by steveklabnik

…teveklabnik Add top level sections to the Unstable Book. Prior to this commit, the contents of the Unstable Book were assumed to be unstable features. This commit moves features into 'language features' or 'library features' subsections. It also moves the 'linker_flavor' compiler flag into a new 'Compiler Flags' subsection. Even though it was helpful, I removed the tidy check that cross-references the SUMMARY.md links with the Unstable Book directory contents just because it would be difficult to maintain. Relevant PR: rust-lang#41142.

Rollup of 7 pull requests - Successful merges: #41295, #41348, #41374, #41380, #41391, #41398, #41403 - Failed merges: #41376

rust-lang/rust#41295

rust-highfive assigned steveklabnik Apr 14, 2017

frewsxcv force-pushed the frewsxcxv-unstability branch 2 times, most recently from e578268 to 4592345Compare April 14, 2017 03:04

frewsxcv added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Apr 14, 2017

frewsxcv force-pushed the frewsxcxv-unstability branch from 4592345 to 952b14dCompare April 14, 2017 03:06

Mark-Simulacrum reviewed Apr 14, 2017
View reviewed changes

frewsxcv force-pushed the frewsxcxv-unstability branch from 952b14d to 8dd523eCompare April 14, 2017 12:47

shepmaster added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 14, 2017

frewsxcv force-pushed the frewsxcxv-unstability branch 3 times, most recently from 66aa506 to ae71ca1Compare April 15, 2017 19:03

frewsxcv force-pushed the frewsxcxv-unstability branch from ae71ca1 to 400ed25Compare April 15, 2017 19:59

frewsxcv force-pushed the frewsxcxv-unstability branch from 400ed25 to 888bfa7Compare April 16, 2017 15:58

frewsxcv added a commit to frewsxcv/book that referenced this pull request Apr 17, 2017
Update Unstable Book links to reflect to new layout.
2c034e3
Fixesrust-lang/rust#41295.

frewsxcv added a commit to frewsxcv/book that referenced this pull request Apr 17, 2017
Update Unstable Book links to reflect to new layout.
98b18fa
rust-lang/rust#41295

frewsxcv mentioned this pull request Apr 17, 2017
Update Unstable Book links to reflect to new layout. rust-lang/book#631
Merged

frewsxcv added a commit to frewsxcv/reference that referenced this pull request Apr 17, 2017
Update Unstable Book links to reflect to new layout.
ec009f0
rust-lang/rust#41295

frewsxcv mentioned this pull request Apr 17, 2017
Update Unstable Book links to reflect to new layout. rust-lang/reference#42
Merged

frewsxcv force-pushed the frewsxcxv-unstability branch from 888bfa7 to fc62ba6Compare April 17, 2017 21:09

frewsxcv added 2 commits April 18, 2017 21:26

Bump book and reference.
bf202c8

frewsxcv force-pushed the frewsxcxv-unstability branch from 19851f4 to bf202c8Compare April 19, 2017 01:26

frewsxcv mentioned this pull request Apr 19, 2017
Rollup of 8 pull requests #41385
Closed

frewsxcv mentioned this pull request Apr 19, 2017
Rollup of 6 pull requests #41387
Closed

Remove platform-specific directory separator.
2e2a670

frewsxcv mentioned this pull request Apr 19, 2017
Rollup of 7 pull requests #41400
Closed

frewsxcv mentioned this pull request Apr 20, 2017
Rollup of 7 pull requests #41411
Merged

bors added a commit that referenced this pull request Apr 20, 2017
Auto merge of#41411- frewsxcv:rollup, r=frewsxcv
1bb1530
Rollup of 7 pull requests - Successful merges: #41295, #41348, #41374, #41380, #41391, #41398, #41403 - Failed merges: #41376

bors merged commit 2e2a670 into rust-lang:masterApr 20, 2017

This was referenced Apr 20, 2017
Document other kinds of unstability in The Unstable Book #41142
Closed
More methods for str boxes. (reduce Box<[u8]> ↔ Box<str> transmutes) #41258
Merged
Implementation of repr struct alignment RFC 1358. #39999
Merged

est31 mentioned this pull request May 23, 2017
Create sections inside the unstable book #41289
Closed

gypsydave5 pushed a commit to gypsydave5/book that referenced this pull request Nov 17, 2017
Update Unstable Book links to reflect to new layout.
415f72e
rust-lang/rust#41295

ksasar1000 added a commit to ksasar1000/emoji that referenced this pull request Nov 25, 2025
https://github.com/rust-lang/rust/pull/41295
d0bfa94

ksasar1000 added a commit to ksasar1000/js.ipfs.io that referenced this pull request Nov 25, 2025
https://github.com/rust-lang/rust/pull/41295
f49a3dd

Uh oh!

Uh oh!

Conversation

frewsxcv commented Apr 14, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Apr 14, 2017

Uh oh!

Mark-SimulacrumApr 14, 2017

Choose a reason for hiding this comment

Uh oh!

steveklabnik commented Apr 14, 2017

Uh oh!

frewsxcv commented Apr 14, 2017

Uh oh!

bors commented Apr 15, 2017

Uh oh!

frewsxcv commented Apr 15, 2017

Uh oh!

frewsxcv commented Apr 16, 2017

Uh oh!

frewsxcv commented Apr 16, 2017

Uh oh!

bors commented Apr 16, 2017

Uh oh!

steveklabnik commented Apr 17, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frewsxcv commented Apr 17, 2017

Uh oh!

steveklabnik commented Apr 17, 2017

Uh oh!

frewsxcv commented Apr 19, 2017

Uh oh!

bors commented Apr 19, 2017

Uh oh!

eddyb commented Apr 19, 2017

Uh oh!

frewsxcv commented Apr 19, 2017

Uh oh!

bors commented Apr 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

frewsxcv commented Apr 14, 2017•
edited
Loading

steveklabnik commented Apr 17, 2017•
edited
Loading