Uh oh!
There was an error while loading. Please reload this page.
Run tests for the cargo submodule in tree - #41362
Merged
Merged
Conversation
rust-highfive
commented
Apr 18, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
arielb1
commented
Apr 18, 2017
Contributor
// One of the projects being tested here is Cargo, and when being tested// Cargo will at some point call `nmake.exe` on Windows MSVC. Unfortunately// `nmake` will read these two environment variables below and try to// intepret them. We're likely being run, however, from MSYS `make` which// uses the same variables.//// As a result, to prevent confusion and errors, we remove these variables// from our environment to prevent passing MSYS make flags to nmake, causing// it to blow up.ifcfg!(target_env = "msvc"){
env::remove_var("MAKE");
env::remove_var("MAKEFLAGS");} |
alexcrichton
commented
Apr 18, 2017
MemberAuthor
Nice catch! Moved over to rustbuild |
alexcrichtonforce-pushed
the
run-cargot-ests
branch
from
April 18, 2017 13:09
61c1a89 to
2c9d756Compareaturon
commented
Apr 18, 2017
Contributor
@bors: r+ |
bors
commented
Apr 18, 2017
Collaborator
📌 Commit 2c9d756 has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 19, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
bors
commented
Apr 19, 2017
Collaborator
⌛ Testing commit 2c9d756 with merge b12057c... |
bors
commented
Apr 19, 2017
Collaborator
💔 Test failed - status-travis |
alexcrichton
commented
Apr 19, 2017
MemberAuthor
@bors: retry
|
bors
commented
Apr 20, 2017
Collaborator
⌛ Testing commit 2c9d756 with merge da63ca9... |
bors
commented
Apr 21, 2017
Collaborator
⌛ Testing commit 787f98d with merge 33ba984... |
bors
commented
Apr 21, 2017
Collaborator
💔 Test failed - status-travis |
frewsxcv
commented
Apr 21, 2017
Contributor
bors
commented
Apr 22, 2017
Collaborator
☔ The latest upstream changes (presumably #41464) made this pull request unmergeable. Please resolve the merge conflicts. |
Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
alexcrichtonforce-pushed
the
run-cargot-ests
branch
from
April 24, 2017 15:08
787f98d to
009f45fComparealexcrichton
commented
Apr 24, 2017
MemberAuthor
@bors: r=aturon |
bors
commented
Apr 24, 2017
Collaborator
📌 Commit 009f45f has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 24, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 24, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 25, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
bors added a commit
that referenced
this pull request
Apr 25, 2017
Run tests for the cargo submodule in tree Previously the `cargotest` suite would run some arbitrary revision of Cargo's test suite, but now that we're bundling it in tree we should be running the Cargo submodule's test suite instead.
bors
commented
Apr 25, 2017
Collaborator
This was referenced Apr 25, 2017
bors
commented
Apr 25, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
cargotestsuite would run some arbitrary revision of Cargo'stest suite, but now that we're bundling it in tree we should be running the
Cargo submodule's test suite instead.