Uh oh!
There was an error while loading. Please reload this page.
Rollup of 3 pull requests - #41363
Conversation
This no longer manifests on any versions of OSX that I could find.
Because of its "magic" order-of-evaluation semantics, `move_val_init` must be lowered during MIR construction in order to work.
Improve Process::spawn with piped stdio on Redox - Adds `dup2`, and uses it for stdio piping - Removes `O_CLOEXEC` from piped stdio, as `dup` on Redox does not disable O_CLOEXEC
…xcrichton bootstrap: Don't workaround uname -m on Darwin This no longer manifests on any versions of OSX that I could find. How far back is Rust officially supported? I can try to get copies to test when this behaviour changed. (Fun fact, at a minimum the comment already lies, since the flag is `-m` :))
lower `move_val_init` during MIR construction Because of its "magic" order-of-evaluation semantics, `move_val_init` must be lowered during MIR construction in order to work without needing a temporary. r? @eddyb
rust-highfive
commented
Apr 18, 2017
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
frewsxcv
commented
Apr 18, 2017
@bors r+ p=10 |
bors
commented
Apr 18, 2017
📌 Commit 4c15b6b has been approved by |
bors
commented
Apr 18, 2017
⌛ Testing commit 4c15b6b with merge 1c638c9... |
frewsxcv
commented
Apr 18, 2017
Closed because mac builders ran into #40061 |
move_val_initduring MIR construction #41361