appveyor: Upgrade to gcc for mingw 6.3.0 by alexcrichton · Pull Request #41420 · rust-lang/rust

alexcrichton · 2017-04-20T15:38:21Z

This commit sort of brings back #40777 by upgrading back to 6.3.0. While
investigating #40546 it was discovered that 6.3.0 appears to not spurious
fail in the same way that 6.2.0 does (which we're currently using). The
workaround for #40184 contained in #40777 did not work so this commit also
contains a different workaround for the gdb issue. We will not download the
6.2.0 version of gdb and use that instead of the default version that comes with
6.3.0.

I'm going to optimistically say...

Closes#40546

rust-highfive · 2017-04-20T15:38:32Z

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

shepmaster · 2017-04-21T13:59:42Z

Thanks for the PR, @alexcrichton! We'll rustle up a review from @brson for you!

TimNN · 2017-04-22T16:30:52Z

@alexcrichton: Can you upload the respective posix threads versions as well?

alexcrichton · 2017-04-24T15:07:51Z

@TimNN already done :)

I actually thought we had already upgraded and when I got around to actually making a PR I noticed I didn't have to...

We should have win32/pthread 6.2.0/6.3.0 all uploaded

bors · 2017-04-25T01:25:24Z

☔ The latest upstream changes (presumably #40123) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2017-04-25T05:42:31Z

Updated

petrochenkov · 2017-04-25T08:26:27Z

@bors r+

bors · 2017-04-25T08:26:28Z

📌 Commit 3b33913 has been approved by petrochenkov

alexcrichton · 2017-04-25T17:08:42Z

@bors: p=1

(hopefully fixing a lot of spurious failures with this)

…enkov appveyor: Upgrade to gcc for mingw 6.3.0 This commit sort of brings back rust-lang#40777 by upgrading back to 6.3.0. While investigating rust-lang#40546 it was discovered that 6.3.0 appears to not spurious fail in the same way that 6.2.0 does (which we're currently using). The workaround for rust-lang#40184 contained in rust-lang#40777 did not work so this commit also contains a different workaround for the gdb issue. We will not download the 6.2.0 version of gdb and use that instead of the default version that comes with 6.3.0. I'm going to optimistically say... Closesrust-lang#40546

bors · 2017-04-25T22:12:14Z

⌛ Testing commit 3b33913 with merge 9a8b446...

bors · 2017-04-25T22:13:10Z

💔 Test failed - status-appveyor

Mark-Simulacrum · 2017-04-25T22:23:24Z

Non-spurious failure. @alexcrichton said on IRC that they probably forgot to upload artifacts.

alexcrichton · 2017-04-25T23:06:18Z

@bors: r=petrochenkov

bors · 2017-04-25T23:06:19Z

📌 Commit d7d2e5c has been approved by petrochenkov

bors · 2017-04-25T23:22:23Z

⌛ Testing commit d7d2e5c with merge 690233d...

bors · 2017-04-25T23:23:39Z

💔 Test failed - status-appveyor

alexcrichton · 2017-04-26T03:25:09Z

@bors: r=petrochenkov

bors · 2017-04-26T03:25:09Z

📌 Commit e239e47 has been approved by petrochenkov

bors · 2017-04-26T06:16:20Z

⌛ Testing commit e239e47 with merge e28a4f6...

bors · 2017-04-26T06:18:14Z

💔 Test failed - status-appveyor

Mark-Simulacrum · 2017-04-26T12:05:14Z

Legitimate failure:

mv: cannot stat '2017-04-20-32bits-gdborig.exe': No such file or directory

Mark-Simulacrum · 2017-04-26T12:05:54Z

bits needs to be bit here.

This commit sort of brings back rust-lang#40777 by upgrading back to 6.3.0. While investigating rust-lang#40546 it was discovered that 6.3.0 appears to not spurious fail in the same way that 6.2.0 does (which we're currently using). The workaround for rust-lang#40184 contained in rust-lang#40777 did not work so this commit also contains a different workaround for the gdb issue. We will not download the 6.2.0 version of gdb and use that instead of the default version that comes with 6.3.0. I'm going to optimistically say... Closesrust-lang#40546

alexcrichton · 2017-04-26T13:59:13Z

@bors: r=petrochenkov

I sure wish there was like an appveyor-simulate command ...

bors · 2017-04-26T13:59:14Z

📌 Commit d1db74b has been approved by petrochenkov

bors · 2017-04-26T15:12:36Z

⌛ Testing commit d1db74b with merge 0369832...

appveyor: Upgrade to gcc for mingw 6.3.0 This commit sort of brings back #40777 by upgrading back to 6.3.0. While investigating #40546 it was discovered that 6.3.0 appears to not spurious fail in the same way that 6.2.0 does (which we're currently using). The workaround for #40184 contained in #40777 did not work so this commit also contains a different workaround for the gdb issue. We will not download the 6.2.0 version of gdb and use that instead of the default version that comes with 6.3.0. I'm going to optimistically say... Closes#40546

alexcrichton · 2017-04-26T18:56:47Z

Homu's having trouble, but tests passed, so merging

alexcrichton · 2017-04-26T18:58:24Z

er travis -- https://travis-ci.org/rust-lang/rust/builds/226048511
appveyor - https://ci.appveyor.com/project/rust-lang/rust/build/1.0.3063

rust-highfive assigned brson Apr 20, 2017

shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2017

alexcrichton force-pushed the mingw-6.3.0 branch from dfec154 to 3b33913Compare April 25, 2017 05:42

arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2017

arielb1 mentioned this pull request Apr 25, 2017
Rollup of 15 pull requests #41539
Closed

alexcrichton force-pushed the mingw-6.3.0 branch from 3b33913 to d7d2e5cCompare April 25, 2017 23:06

alexcrichton force-pushed the mingw-6.3.0 branch from d7d2e5c to e239e47Compare April 26, 2017 03:24

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 26, 2017

Mark-Simulacrum reviewed Apr 26, 2017
View reviewed changes

Comment threadappveyor.yml Outdated
Mark-SimulacrumApr 26, 2017
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bits needs to be bit here.

alexcrichton force-pushed the mingw-6.3.0 branch from e239e47 to d1db74bCompare April 26, 2017 13:58

alexcrichton merged commit d1db74b into rust-lang:masterApr 26, 2017

alexcrichton deleted the mingw-6.3.0 branch April 26, 2017 18:58

alexcrichton mentioned this pull request Apr 29, 2017
Spurious failures on AppVeyor due to ar.exe errors #40546
Closed

Uh oh!

Uh oh!

Conversation

alexcrichton commented Apr 20, 2017

Uh oh!

rust-highfive commented Apr 20, 2017

Uh oh!

shepmaster commented Apr 21, 2017

Uh oh!

TimNN commented Apr 22, 2017

Uh oh!

alexcrichton commented Apr 24, 2017

Uh oh!

bors commented Apr 25, 2017

Uh oh!

alexcrichton commented Apr 25, 2017

Uh oh!

petrochenkov commented Apr 25, 2017

Uh oh!

bors commented Apr 25, 2017

Uh oh!

alexcrichton commented Apr 25, 2017

Uh oh!

bors commented Apr 25, 2017

Uh oh!

bors commented Apr 25, 2017

Uh oh!

Mark-Simulacrum commented Apr 25, 2017

Uh oh!

alexcrichton commented Apr 25, 2017

Uh oh!

bors commented Apr 25, 2017

Uh oh!

bors commented Apr 25, 2017

Uh oh!

bors commented Apr 25, 2017

Uh oh!

alexcrichton commented Apr 26, 2017

Uh oh!

bors commented Apr 26, 2017

Uh oh!

bors commented Apr 26, 2017

Uh oh!

bors commented Apr 26, 2017

Uh oh!

Mark-Simulacrum commented Apr 26, 2017

Uh oh!

Mark-SimulacrumApr 26, 2017

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Apr 26, 2017

Uh oh!

bors commented Apr 26, 2017

Uh oh!

bors commented Apr 26, 2017

Uh oh!

alexcrichton commented Apr 26, 2017

Uh oh!

alexcrichton commented Apr 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants