Update release notes for 1.17 by brson · Pull Request #41548 · rust-lang/rust

brson · 2017-04-26T01:04:41Z

Rendered.

cc @steveklabnik

rust-highfive · 2017-04-26T01:04:52Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

KiChjang · 2017-04-26T01:06:55Z

Typo: subtyping

Mark-Simulacrum · 2017-04-26T01:14:46Z

I don't see Cell::swap, Cell::replace, Cell::into_inner, and Cell::take at all in the stable documentation. That's suspicious to me, since it feels like it was then stabilized within less than a cycle; perhaps unintentionally? I'm not sure. I don't know what the procedure around minor library stabilizations is, either. The other stabilized APIs are in the stable documentation, which is why I bring this up.

@Mark-Simulacrum
Swap: Add swap method for Cell #39716 (comment)
The rest: Tracking issue for RFC 1651: Extend Cell to non-Copy types #39264 (comment)

@Mark-Simulacrum afaict that is the case. These were stabilized within a single cycle.

SimonSapin · 2017-04-26T03:26:14Z

Based on the linked PR it looks like only the constructors of such structs are private, the types are still public (assuming pub struct …)

Yes, good catch.

kevinmehall · 2017-04-26T03:53:36Z

Wasn't the "skipping runtime-internal stack frames" part reverted?

Seems like it.

kevinmehall · 2017-04-26T03:56:34Z

ICES -> ICEs

alexcrichton · 2017-04-26T04:24:48Z

r=me when this is good to go

arielb1 · 2017-04-26T09:09:38Z

That's the same as #32330.

brson · 2017-04-26T16:43:20Z

Updated.

CryZe · 2017-04-27T16:07:10Z

{Arc/Rc}::ptr_eq got stabilized with 1.17 too: https://doc.rust-lang.org/beta/std/rc/struct.Rc.html#method.ptr_eq

brson · 2017-04-27T16:19:00Z

Thanks @CryZe. Updated.

alexcrichton · 2017-05-04T18:29:44Z

@brson was this waiting on anything else? Or is this ready to go?

carols10cents · 2017-05-08T13:47:47Z

Hm one of the travis jobs is marked as cancelled after 45 min 32 sec? Is that a timeout? I'm retrying it within travis...

brson · 2017-05-09T19:25:57Z

Nah this is done.

@bors r+

bors · 2017-05-09T19:25:58Z

📌 Commit 8e97693 has been approved by brson

bors · 2017-05-09T23:12:00Z

⌛ Testing commit 8e97693 with merge db1c9eb...

@steveklabnik

Update release notes for 1.17 [Rendered](https://github.com/brson/rust/blob/relnotes/RELEASES.md). cc @steveklabnik

bors · 2017-05-10T02:32:10Z

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing db1c9eb to master...

@alexcrichton

[beta] backports - #41666 - #41578 - #41548 - #41529 r? @alexcrichton

rust-highfive assigned alexcrichton Apr 26, 2017

KiChjang reviewed Apr 26, 2017
View reviewed changes

Comment threadRELEASES.md Outdated
KiChjangApr 26, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: subtyping

Mark-Simulacrum reviewed Apr 26, 2017
View reviewed changes

SimonSapin reviewed Apr 26, 2017
View reviewed changes

kevinmehall reviewed Apr 26, 2017
View reviewed changes

Comment threadRELEASES.md Outdated
kevinmehallApr 26, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ICES -> ICEs

alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 26, 2017

arielb1 reviewed Apr 26, 2017
View reviewed changes

Comment threadRELEASES.md Outdated
arielb1Apr 26, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the same as #32330.

aidanhs added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 26, 2017

brson force-pushed the relnotes branch from f41f151 to 6115993Compare April 26, 2017 16:42

Update release notes for 1.17
8e97693

brson force-pushed the relnotes branch from 6115993 to 8e97693Compare April 27, 2017 16:18

bors added a commit that referenced this pull request May 9, 2017
Auto merge of#41548- brson:relnotes, r=brson
db1c9eb
Update release notes for 1.17 [Rendered](https://github.com/brson/rust/blob/relnotes/RELEASES.md). cc @steveklabnik

bors merged commit 8e97693 into rust-lang:masterMay 10, 2017

brson mentioned this pull request May 10, 2017
[beta] backports #41899
Merged

alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 10, 2017

bors added a commit that referenced this pull request May 11, 2017
Auto merge of#41899- brson:backports, r=alexcrichton
4978d58
[beta] backports - #41666 - #41578 - #41548 - #41529 r? @alexcrichton

Uh oh!

Uh oh!

Conversation

brson commented Apr 26, 2017

Uh oh!

rust-highfive commented Apr 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kennytmApr 26, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Apr 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brson commented Apr 26, 2017

Uh oh!

CryZe commented Apr 27, 2017

Uh oh!

brson commented Apr 27, 2017

Uh oh!

alexcrichton commented May 4, 2017

Uh oh!

carols10cents commented May 8, 2017

Uh oh!

brson commented May 9, 2017

Uh oh!

bors commented May 9, 2017

Uh oh!

bors commented May 9, 2017

Uh oh!

bors commented May 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

kennytmApr 26, 2017•
edited
Loading