Uh oh!
There was an error while loading. Please reload this page.
librustc: Fix explicit self for objects in more cases - #4155
Closed
pcwalton wants to merge 1 commit into
Closed
Conversation
nikomatsakis
commented
Dec 11, 2012
Contributor
I don't fully see why we need to do things so differently for objects. I feel like the vtables should contains functions that perform whatever adaptation is needed. That said, r+ to this patch, which seems like an improvement on the current state. |
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Feb 2, 2025
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
4155: Precompute expected type during completion r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis