Skip to content

impl Clone for .split_whitespace() - #41659

Merged
bors merged 2 commits into
rust-lang:masterfrom
bluss:clone-split-whitespace
May 10, 2017
Merged

impl Clone for .split_whitespace()#41659
bors merged 2 commits into
rust-lang:masterfrom
bluss:clone-split-whitespace

Conversation

@bluss

@blussbluss commented Apr 30, 2017

Copy link
Copy Markdown
Contributor

Use custom closure structs for the predicates so that the iterator's
clone can simply be derived. This should also reduce virtual call
overhead by not using function pointers.

Fixes#41655

@bluss
std_unicode: impl Clone for .split_whitespace()
f41ecef
Use custom closure structs for the predicates so that the iterator's
clone can simply be derived. This should also reduce virtual call
overhead by not using function pointers.
@rust-highfive

rust-highfive commented Apr 30, 2017

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@bluss

bluss commented Apr 30, 2017

Copy link
Copy Markdown
ContributorAuthor

It's not pretty but I think it's OK to use this long kind of implementation due to its positive features.

@carols10centscarols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2017
@arielb1

arielb1 commented May 2, 2017

Copy link
Copy Markdown
Contributor

r? @aturon

@arielb1arielb1 assigned aturon and unassigned nikomatsakisMay 2, 2017
@arielb1
arielb1 requested a review from aturonMay 2, 2017 09:44
@arielb1

arielb1 commented May 2, 2017

Copy link
Copy Markdown
Contributor

Thanks for the PR @bluss. @aturon (or someone else) should be reviewing your PR shortly.

@nikomatsakis

nikomatsakis commented May 2, 2017

Copy link
Copy Markdown
Contributor

cc @rust-lang/libs (code seems fine to me; and I can't see any reason that this iterator shouldn't be iterable...)

@alexcrichtonalexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label May 3, 2017
@alexcrichton

alexcrichton commented May 3, 2017

Copy link
Copy Markdown
Member

@rfcbot fcp merge

@rfcbot

rfcbot commented May 3, 2017•
edited by BurntSushi
Loading

Copy link
Copy Markdown

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@aturon

aturon commented May 5, 2017

Copy link
Copy Markdown
Contributor

LGTM. r=me once libs has signed off (new stable addition to std).

@Mark-SimulacrumMark-Simulacrum added S-waiting-on-team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2017
@aturon

aturon commented May 9, 2017

Copy link
Copy Markdown
Contributor

@bors: r+

@bors

bors commented May 9, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 41aeb9d has been approved by aturon

@rfcbot

rfcbot commented May 9, 2017

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbotrfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label May 9, 2017
@frewsxcvfrewsxcv mentioned this pull request May 10, 2017
Closed
@bors

bors commented May 10, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 41aeb9d with merge 58b33ad...

bors added a commit that referenced this pull request May 10, 2017
@bors
Auto merge of#41659- bluss:clone-split-whitespace, r=aturon
58b33ad
impl Clone for .split_whitespace()
Use custom closure structs for the predicates so that the iterator's
clone can simply be derived. This should also reduce virtual call
overhead by not using function pointers.
Fixes#41655
@bors

bors commented May 10, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 58b33ad to master...

@bors
bors merged commit 41aeb9d into rust-lang:masterMay 10, 2017
@bluss
bluss deleted the clone-split-whitespace branch May 10, 2017 17:18
@blussbluss added the relnotes Marks issues that should be documented in the release notes of the next release. label May 10, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aturonaturonAwaiting requested review from aturon

Assignees

@aturonaturon

Labels

final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.relnotesMarks issues that should be documented in the release notes of the next release.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@bluss@rust-highfive@arielb1@nikomatsakis@alexcrichton@rfcbot@aturon@bors@carols10cents@Mark-Simulacrum