Reverse the order of the results of pipes::stream - #4167
Merged
Conversation
Contributor
|
r+ |
catamorphism
added a commit
that referenced
this pull request
Dec 12, 2012
Reverse the order of the results of pipes::stream
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Feb 2, 2025
clarify apply_random_float_error logic
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
4167: Filter out code actions if unsupported by the client and advertise our capabilities r=matklad a=kjeremy This PR does three things: 1. If the client does not support `CodeActionKind` this will filter the results and only send `Command[]` back. 2. Correctly advertises to the client that the server supports `CodeActionKind`. This may cause clients to not request code actions if they are checking for the provider to be `true` (or implement LSP < 3.8) in the caps but I will fix that in a followup PR. 3. Marks most CodeActions as <strike>"refactor" so that they show up in the menu in vscode.</strike>`""`. Part of rust-lang#144 rust-lang#4147 rust-lang#2833 Co-authored-by: kjeremy <kjeremy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #3637.
There's nothing worth looking at in the diffs themselves, but I thought I'd submit a pull request because I'm not sure whether there was consensus for the change. (everyone was for it, but not everyone commented).
r? @brson