Skip to content

Remove obsolete --disable-elf-tls configure switch. - #41687

Merged
bors merged 1 commit into
rust-lang:masterfrom
rillian:no-elf-tls
May 4, 2017
Merged

Remove obsolete --disable-elf-tls configure switch.#41687
bors merged 1 commit into
rust-lang:masterfrom
rillian:no-elf-tls

Conversation

@rillian

Copy link
Copy Markdown
Contributor

Support for disabling ELF-style thread local storage in
the standard library at configure time was removed in
pulls #30417 and #30678, in favour of a member in
the TargetOptions database. The new mentod respects
MACOSX_DEPLOYMENT_TARGET on macOS, addressing the
original use case for this configure optionl

However, those commits left the configure option itself
in place. It's no longer referenced anywhere and can
be removed.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rillian

Copy link
Copy Markdown
ContributorAuthor

Per #32047, this switch isn't connected to anything any more. In #30678 (comment)@alexcrichton asked that the switch remain available to avoid breaking anyone's build scripts. That was over a year ago though, and in particular I know we no longer need this for Gecko, so I think it's less confusing to remove it at this point.

@arielb1arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2017
Support for disabling ELF-style thread local storage in
the standard library at configure time was removed in
pulls rust-lang#30417 and rust-lang#30678, in favour of a member in
the TargetOptions database. The new method respects
MACOSX_DEPLOYMENT_TARGET on macOS, addressing the
original use case for this configure option.
However, those commits left the configure option itself
in place. It's no longer referenced anywhere and can
be removed.
@aturon

Copy link
Copy Markdown
Contributor

Note that @alexcrichton, in that comment, also suggested a deprecation warning (which is our usual practice before removal). AFAIK no such warning was implemented?

This is largely a policy question, so I'd like to bring in @rust-lang/compiler for their thoughts as well. (I don't personally have a strong opinion here.)

@alexcrichton

Copy link
Copy Markdown
Member

I doubt anyone ever really used this much less even knew about it, I don't think we need much ceremony to remove it personally, it's a tiny option when building rust that's easy to remove if it even needs to be.

@aturon

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented May 4, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 19cab63 has been approved by aturon

@bors

bors commented May 4, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 19cab63 with merge 222971f...

bors added a commit that referenced this pull request May 4, 2017
Remove obsolete --disable-elf-tls configure switch.
Support for disabling ELF-style thread local storage in
the standard library at configure time was removed in
pulls #30417 and #30678, in favour of a member in
the TargetOptions database. The new mentod respects
MACOSX_DEPLOYMENT_TARGET on macOS, addressing the
original use case for this configure optionl
However, those commits left the configure option itself
in place. It's no longer referenced anywhere and can
be removed.
@bors

bors commented May 4, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 222971f to master...

@bors
bors merged commit 19cab63 into rust-lang:masterMay 4, 2017
@rillian

Copy link
Copy Markdown
ContributorAuthor

Thanks @aturon, @alexcrichton. I didn't implement a deprecation warning because the functionality was already broken. Anyone who was setting this in a build script wasn't getting what they expected anyway.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@rillian@rust-highfive@aturon@alexcrichton@bors@arielb1