Uh oh!
There was an error while loading. Please reload this page.
join method returns a thread::Result - #41741
Conversation
rust-highfive
commented
May 4, 2017
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
rap2hpoutre
commented
May 4, 2017
r? @steveklabnik (I think it's you, cause you created the issue) |
steveklabnik
commented
May 4, 2017
You're not wrong! While There's one problem with this PR, though, I think: you haven't created the actual link yet! That is, this won't inherently generate a link; check out all the stuff at the bottom of the comment block. Let me know if that doesn't make sense and I can help out! |
rap2hpoutre
commented
May 4, 2017
Thank you! I'm sorry I did not noticed that. I tried to fix this by myself (last commit). Though I'm still not sure I did it well. Is there a documentation for this (how to link in doc)? |
| //! [`panic!`]: ../../std/macro.panic.html | ||
| //! [`Builder`]: ../../std/thread/struct.Builder.html | ||
| //! [`thread::current`]: ../../std/thread/fn.current.html | ||
| //! [`thread::Result`]: ../../std/thread/struct.Result.html |
There was a problem hiding this comment.
this should be ../../std/thread/type.Result.html
type not struct :)
steveklabnik
commented
May 4, 2017
It's Markdown syntax, so we don't have specific docs for it, since any markdown reference covers it. That said, you got it perfect, except one tiny little thing. If we change that it's good to go! |
rap2hpoutre
commented
May 4, 2017
Oops. Done! Thanks again for mentoring!! |
steveklabnik
commented
May 4, 2017
@bors: r+ rollup Thank you for the contribution! 🎊 |
bors
commented
May 4, 2017
📌 Commit 93e179a has been approved by |
join method returns a thread::Result Join method returns a std::thread::Result, not a std::result::Result: https://doc.rust-lang.org/std/thread/struct.JoinHandle.html#method.join Maybe I misunderstood something. I have seen this mistake(?) because I wanted to tackle this issue rust-lang#29378 (about Result). It's still one of my first PR. Sorry if I missed something.
join method returns a thread::Result Join method returns a std::thread::Result, not a std::result::Result: https://doc.rust-lang.org/std/thread/struct.JoinHandle.html#method.join Maybe I misunderstood something. I have seen this mistake(?) because I wanted to tackle this issue rust-lang#29378 (about Result). It's still one of my first PR. Sorry if I missed something.
Join method returns a std::thread::Result, not a std::result::Result: https://doc.rust-lang.org/std/thread/struct.JoinHandle.html#method.join Maybe I misunderstood something.
I have seen this mistake(?) because I wanted to tackle this issue #29378 (about Result). It's still one of my first PR. Sorry if I missed something.