Skip to content

try to fix lvalue ops for real - #41828

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:lvalue-ops
May 9, 2017
Merged

try to fix lvalue ops for real#41828
bors merged 1 commit into
rust-lang:masterfrom
arielb1:lvalue-ops

Conversation

@arielb1

Copy link
Copy Markdown
Contributor

Hopefully this is the last PR needed.

Fixes#41726.
Fixes#41742.
Fixes#41774.

Hopefully this is the last PR needed.
Fixesrust-lang#41726.
Fixesrust-lang#41742.
Fixesrust-lang#41774.
@arielb1

Copy link
Copy Markdown
ContributorAuthor

r? @eddyb

@rust-highfiverust-highfive assigned eddyb and unassigned pnkfelixMay 8, 2017
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb

eddyb commented May 8, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 8, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 052d071 has been approved by eddyb

@frewsxcvfrewsxcv mentioned this pull request May 9, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 9, 2017
try to fix lvalue ops for real
Hopefully this is the last PR needed.
Fixesrust-lang#41726.
Fixesrust-lang#41742.
Fixesrust-lang#41774.
@frewsxcvfrewsxcv mentioned this pull request May 9, 2017
bors added a commit that referenced this pull request May 9, 2017
Rollup of 8 pull requests
- Successful merges: #41293, #41520, #41827, #41828, #41833, #41836, #41838, #41842
- Failed merges:
@bors
bors merged commit 052d071 into rust-lang:masterMay 9, 2017
@bors

bors commented May 9, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 052d071 with merge bedd7da...

@arielb1arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 10, 2017
@arielb1

Copy link
Copy Markdown
ContributorAuthor

Beta-nominating because this fixes regression introduces in #41578 which is going into beta.

@arielb1arielb1 mentioned this pull request May 10, 2017
@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 17, 2017
@nikomatsakis

Copy link
Copy Markdown
Contributor

Accepting for beta. Small-ish patch, serious soundness regressions.

cc @rust-lang/compiler

@nikomatsakisnikomatsakis added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 17, 2017
@nikomatsakis

Copy link
Copy Markdown
Contributor

Backport in #42053

bors added a commit that referenced this pull request May 22, 2017
Beta backport various arielb1 patches
Backport of the following PRs:
- #41651
- #41828
cc @arielb1@rust-lang/compiler
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 23, 2017
@brson

Copy link
Copy Markdown
Contributor

Looks like this has been backported. Removed the nominated tag.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@arielb1@rust-highfive@eddyb@bors@nikomatsakis@brson@pnkfelix