Skip to content

Suppress trait errors that are implied by other errors - #41840

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:deduplicate-selection-errors
Jun 16, 2017
Merged

Suppress trait errors that are implied by other errors#41840
bors merged 1 commit into
rust-lang:masterfrom
arielb1:deduplicate-selection-errors

Conversation

@arielb1

@arielb1arielb1 commented May 8, 2017

Copy link
Copy Markdown
Contributor

this is currently a hack and should be cleaned up somewhat. Posting this to get some feedback.

r? @nikomatsakis
cc @estebank

@estebankestebank mentioned this pull request May 8, 2017
Closed
estebank
estebank reviewed May 8, 2017
View reviewed changes
Comment threadsrc/test/compile-fail/range_traits-1.rs Outdated

@estebankestebankMay 8, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, could you clean these up to use //~| instead of //~^^^^^?

@arielb1arielb1 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 9, 2017
nikomatsakis
nikomatsakis reviewed May 15, 2017
View reviewed changes

@nikomatsakisnikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general approach seems reasonably good to me! Sorry for taking so long to give feedback. I'm a bit unsure if we should maybe try to go further?

@carols10cents

carols10cents commented May 22, 2017

Copy link
Copy Markdown
Member

Friendly ping @arielb1, keeping this on your radar!

@bors

bors commented May 23, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #41559) made this pull request unmergeable. Please resolve the merge conflicts.

@arielb1

arielb1 commented May 23, 2017

Copy link
Copy Markdown
ContributorAuthor

status: now that I'm done with the segfaults on #41917 I'll look into this - I'll try to get it done by Monday,

@aidanhs

aidanhs commented Jun 1, 2017

Copy link
Copy Markdown
Contributor

Hi @arielb1, how are you getting on with this?

@arielb1

arielb1 commented Jun 4, 2017

Copy link
Copy Markdown
ContributorAuthor

I am. Just a little bit busy with other stuff.

@nikomatsakis

nikomatsakis commented Jun 7, 2017

Copy link
Copy Markdown
Contributor

@arielb1 I'm going to close this PR for now just to clear up my queue. Feel free to re-open once you have updates available!

@Mark-Simulacrum

Mark-Simulacrum commented Jun 11, 2017

Copy link
Copy Markdown
Member

@nikomatsakis You never closed this PR, so I'm going to assume that was unintentional and close it now. Please do reopen if I'm wrong!

@arielb1arielb1 reopened this Jun 11, 2017
@nikomatsakis

nikomatsakis commented Jun 14, 2017

Copy link
Copy Markdown
Contributor

@arielb1 I guess you'd prefer to keep the PR open? :) seems fine.

@arielb1
arielb1force-pushed the deduplicate-selection-errors branch from 13ffe4a to 06d6fb2CompareJune 14, 2017 19:34
@arielb1arielb1 changed the title [WIP] suppress trait errors that are implied by other errorsSuppress trait errors that are implied by other errorsJun 14, 2017
@arielb1
suppress trait errors that are implied by other errors
7b9519a
Instead of suppressing only trait errors that are "exact duplicates",
display only the "most high-level" error when there are multiple trait
errors with the same span that imply each-other.
e.g. when there are both `[closure]: Fn` and `[closure]: FnOnce`, omit
displaying the `[closure]: FnOnce` bound.
@arielb1
arielb1force-pushed the deduplicate-selection-errors branch from 06d6fb2 to 7b9519aCompareJune 14, 2017 20:35
@nikomatsakis

nikomatsakis commented Jun 15, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

@bors r+

(if you feel, maybe address the nit that @estebank pointed out about converting //~^...^ to //~|, but doesn't seem criticial to me)

@bors

bors commented Jun 15, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 7b9519a has been approved by nikomatsakis

@bors

bors commented Jun 15, 2017

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: Upgrade LLVM #42410

@bors

bors commented Jun 15, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 7b9519a has been approved by nikomatsakis

@bors

bors commented Jun 15, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7b9519a with merge e6861f5...

@bors

bors commented Jun 15, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@arielb1arielb1 mentioned this pull request Jun 16, 2017
Closed
@arielb1

arielb1 commented Jun 16, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors

bors commented Jun 16, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7b9519a with merge 787d9da...

bors added a commit that referenced this pull request Jun 16, 2017
@bors
Auto merge of#41840- arielb1:deduplicate-selection-errors, r=nikoma…
787d9da
…tsakis
Suppress trait errors that are implied by other errors
this is currently a hack and should be cleaned up somewhat. Posting this to get some feedback.
r? @nikomatsakis
cc @estebank
@bors

bors commented Jun 16, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 787d9da to master...

@bors
bors merged commit 7b9519a into rust-lang:masterJun 16, 2017
@borsbors mentioned this pull request Jun 16, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebankestebankestebank left review comments
@nikomatsakisnikomatsakisnikomatsakis approved these changes

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@arielb1@carols10cents@bors@aidanhs@nikomatsakis@Mark-Simulacrum@estebank