Uh oh!
There was an error while loading. Please reload this page.
expose needs_drop under mem - #41892
Conversation
rust-highfive
commented
May 10, 2017
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Gankra
commented
May 11, 2017
Fixed the whitespace errors (had auto-whitespace-trimming disabled since Swift people got mad when you fixed that). The unstable book error thing is uh, new to me. |
aturon
commented
May 12, 2017
cc @rust-lang/libs @rust-lang/lang |
alexcrichton
commented
May 12, 2017
👍 |
There was a problem hiding this comment.
So there's some backstory here: basically this was never implemented in the compiler in a principled way, to account for associated types. I've made the Copy check recursive recently but I don't believe that's relevant here.
What's left is to normalize associated type projections in the recursion and/or make an auto trait and rely on the trait system to handle the structural recursion involved here. cc @nikomatsakis
There was a problem hiding this comment.
@eddyb Is this a bug in the current implementation, and if so, is there an issue tracking it? If not, could you maybe expand on why needs_drop cannot be accurate?
bors
commented
May 13, 2017
☔ The latest upstream changes (presumably #41847) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
commented
May 18, 2017
ping @gankro looks like this needs a rebase? Looks like there's not a whole lot of opinions here, and we don't have a huge amount of ceremony about unstable apis, so I can r+ when you've rebased |
Mark-Simulacrum
commented
May 20, 2017
@aturon You nominated but didn't label with any teams, I've added both that you pinged (T-lang and T-libs). |
Gankra
commented
May 20, 2017
Rebased. |
Mark-Simulacrum
commented
May 20, 2017
@bors r=alexcrichton |
bors
commented
May 20, 2017
📌 Commit 1f01b09 has been approved by |
expose needs_drop under mem Note that I purposefully didn't update the intrinsic's documentation, because I think it makes sense for it be more... "honest" about its semantics.
Note that I purposefully didn't update the intrinsic's documentation, because I think it makes sense for it be more... "honest" about its semantics.