Updated releases notes for 1.18 by XAMPPRocky · Pull Request #41953 · rust-lang/rust

XAMPPRocky · 2017-05-12T14:40:36Z

This is my first time making the release notes so please give it an extra once over!

rust-highfive · 2017-05-12T14:40:42Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

est31 · 2017-05-12T14:45:00Z

+Cargo
+-----
+
+- [Added Pijul support][cargo/3842] Pijul is a version control system in Rust.


Its just partial support, not for dependencies, but only for cargo new.

@est31 Updated to reflect that.

aturon · 2017-05-12T14:49:39Z

cc @rust-lang/libs @rust-lang/compiler

eddyb · 2017-05-12T14:58:39Z

+- [rustc can now emit mir with `--emit mir`][39891]
+- [Improved LLVM IR for trivial functions][40367]
+- [Added explanation for E0090(Wrong number of lifetimes are supplied)][40723]
+- [Rustc is now faster][41469]


This could be more specific, e.g. "Compilation time speedup opportunities found through profiling" but I have no strong preference.

I've updated the wording.

WiSaGaN · 2017-05-12T14:58:51Z

+- [rustc can now emit mir with `--emit mir`][39891]
+- [Improved LLVM IR for trivial functions][40367]
+- [Added explanation for E0090(Wrong number of lifetimes are supplied)][40723]
+- [Rustc is now faster][41469]


According to performance graph, the compilation time was reduced around 15% to 20% across the board if I am not mistaken. This is pretty significant improvement. We might as well let user know the actual number.

I wanted to give a overall number, but I didn't know where to get it. Thanks!

alexcrichton · 2017-05-12T15:51:55Z

+ You can now create new cargo projects with Pijul using `cargo new --vcs pijul`
+- [Now always emits build script warnings for crates that fail to build][cargo/3847]
+- [Added Android build support][cargo/3885]
+- [Added `--all-$KIND` flags][cargo/3901] now you can build all programs


Oh this ended up actually being --tests, --bins, etc, (not --all-$KIND)

alexcrichton · 2017-05-12T15:52:33Z

+- [Added `--all-$KIND` flags][cargo/3901] now you can build all programs
+ of a certain type, for example `cargo build --all-bins` will build all
+ binaries.
+- [Test files are now allowed be named `test.rs`][cargo/3947]


This is mostly a very minor bugfix, it may not be worth mentioning.

alexcrichton · 2017-05-12T15:53:38Z

More library features can be found in #41904 I believe

alexcrichton · 2017-05-12T15:54:15Z

+ the zeroes are placed after the prefix and before the digits.
+- [Optimized insertion sort in slice][40807] insertion sort in some cases
+ 2.50%~ faster and in one case now 12.50% faster.
+- [`ThreadId` now implements `Hash` and `Debug`][41008]


This is an unstable feature I believe, so we may not wish to mention it in the release notes just yet

brson · 2017-05-12T17:30:18Z

Thanks @Aaronepower !

Note that the release notes are still waiting on a library stabilization pr for 1.18.

XAMPPRocky · 2017-05-12T20:11:18Z

@brson I've just added the stabilised APIs section.

leonardo-m · 2017-05-12T20:25:29Z

The "Rustc is now faster" in the "Compiler" section is not a good idea because I've later revealed a regression (probably in the 2017-05-03 Nightly) that has negated those compilation performance improvements.

XAMPPRocky · 2017-05-12T20:31:25Z

@leonardo-m Is there an issue about this?

leonardo-m · 2017-05-12T20:33:28Z

There is no issue, because my code is not public. But the problem should be visible with public crates too, if it's a real one.

eddyb · 2017-05-12T20:43:42Z

cc @arielb1

XAMPPRocky · 2017-05-12T20:45:06Z

@leonardo-m But as @WiSaGaN points out there has been a very clear performance improvement.

Mark-Simulacrum · 2017-05-12T20:46:32Z

I think we can objectively say that the compiler is 15-20% faster based on the tests in perf.rlo; however, this may not apply to all cases (as usual) -- if there's code that doesn't show this improvement, or shows the opposite, that's also possible. However, I think it's reasonable to say that for some workloads we did improve by 15-20%. Without having access to anything beyond "compilation got slower for me, negating those benefits" I'm afraid we can't produce anything actionable :/

ollie27 · 2017-05-12T23:23:57Z

+- [No longer caching stdio on Windows][40516]
+- [Changed how the `0` works in format!][40241] Padding zeroes are now always
+ placed after the sign if it exists and before the digits. With the `#` flag
+ the zeroes are placed after the prefix and before the digits.


I think this should be mentioned in the Compatibility Notes as it's a breaking change.

cuviper · 2017-05-13T00:16:08Z

+Compiler
+--------
+
+- [LLVM backend upgraded to 4.0][40123]


I'm pretty sure LLVM 4 landed just after beta branched, so it will be in 1.19.

aidanhs · 2017-05-18T00:26:55Z

This PR is currently blocked on the merge of #41904 to finalise what's been stabilised (I think tryfrom has been removed from there since these notes were last updated).

brson · 2017-05-22T22:59:34Z

It looks like struct layout optimization is in for 1.18. Can you confirm @camlorn ?

sfackler · 2017-05-22T23:15:15Z

#41904 has landed - just gotta backport to beta.

XAMPPRocky · 2017-05-24T00:27:01Z

@brson It is, I didn't include it initially as the options are behind the unstable flag.

brson · 2017-05-25T16:52:04Z

@Aaronepower hm, I don't see in that patch an indication that it's behind a flag (just the optimization fuel).

Library stabilization backports are in.

Let's get this updated and landed and hopefully backported soon.

brson · 2017-05-25T17:12:27Z

Here's one for the compatibility notes: #41805

mbrubeck · 2017-05-30T17:15:46Z

+ always placed after the sign if it exists and before the digits. With the `#`
+ flag the zeroes are placed after the prefix and before the digits.
+- [Due to the struct field optimisation][40377], using `transmute` on structs
+ that have no `repr` attribute or `#[repr(Rust)]` will longer work.


Perhaps an added note here: "(This has always been undefined behavior, but is now more likely to break in practice.)"

will longer work ↦ will no longer work

kennytm · 2017-05-30T17:37:18Z

+- [`HashMap::retain`]
+- [`HashSet::retain`]
+- [`PeekMut::pop`]
+- [`TcpSteam::peek`]


typo. TcpStream::peek

kennytm · 2017-05-30T17:38:55Z

+ always placed after the sign if it exists and before the digits. With the `#`
+ flag the zeroes are placed after the prefix and before the digits.
+- [Due to the struct field optimisation][40377], using `transmute` on structs
+ that have no `repr` attribute or `#[repr(Rust)]` will longer work.


will longer work ↦ will no longer work

budziq · 2017-05-31T00:26:12Z

+ receiving the wrong priority parsing things like `&for<'a> Tr<'a> + Send` as
+ `&(for<'a> Tr<'a> + Send)` instead of `(&for<'a> Tr<'a>) + Send`
+- [Overlapping inherent `impl`s are now a hard error][40728]
+- [`PartialOrd` and `Ord` must to agree on the ordering.][41270]


typo must to agree -> must agree

brson · 2017-05-31T01:21:52Z

#42068 is going to get a last-minute backport.

brson · 2017-05-31T01:22:34Z

@bors r- probably we should try to land that backport, then land this, then backport the relnotes.

bors · 2017-05-31T01:22:46Z

⌛ Trying commit 9c3e733 with merge a8b46ce...

brson · 2017-05-31T01:28:48Z

@Aaronepower there's a few new comments to address here.

brson · 2017-05-31T01:29:24Z

I'm not sure what bors is doing with this PR atm. Status says "pending (try)", and I just r-ed.

Mark-Simulacrum · 2017-05-31T03:08:37Z

@bors retry

bors · 2017-05-31T03:08:46Z

⌛ Trying commit 9c3e733 with merge a65604c...

Updated releases notes for 1.18 This is my first time making the release notes so please give it an extra once over!

bors · 2017-05-31T03:11:07Z

💔 Test failed - status-travis

Mark-Simulacrum · 2017-05-31T03:11:24Z

Manually canceled the try build to get it out of bors head.

brson · 2017-05-31T18:30:17Z

I addressed remaining nits and added RFC links.

brson · 2017-05-31T18:38:16Z

I took the liberty of squashing. Hope you don't mind @Aaronepower.

Rendered.

ollie27 · 2017-05-31T19:07:25Z

Looks like TcpSteam::peek still isn't fixed.

brson · 2017-06-01T17:28:41Z

Fixed TcpSteam::peek

brson · 2017-06-02T22:36:43Z

@bors r+

bors · 2017-06-02T22:36:44Z

📌 Commit 02c0d3c has been approved by brson

[beta] Updated releases notes for 1.18 - #41953

bors · 2017-06-03T03:57:20Z

⌛ Testing commit 02c0d3c with merge 14526a3...

Updated releases notes for 1.18 This is my first time making the release notes so please give it an extra once over!

bors · 2017-06-03T06:13:01Z

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 14526a3 to master...

rust-highfive assigned aturon May 12, 2017

est31 reviewed May 12, 2017
View reviewed changes

eddyb reviewed May 12, 2017
View reviewed changes

WiSaGaN reviewed May 12, 2017
View reviewed changes

shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2017

alexcrichton reviewed May 12, 2017
View reviewed changes

ollie27 reviewed May 12, 2017
View reviewed changes

cuviper reviewed May 13, 2017
View reviewed changes

aidanhs added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2017

brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 25, 2017

brson mentioned this pull request May 30, 2017
[beta] Updated releases notes for 1.18 #42316
Closed

brson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 30, 2017

mbrubeck reviewed May 30, 2017
View reviewed changes

kennytm reviewed May 30, 2017
View reviewed changes

budziq reviewed May 31, 2017
View reviewed changes

bors added a commit that referenced this pull request May 31, 2017
Auto merge of#41953- Aaronepower:patch-1, r=<try>
a65604c
Updated releases notes for 1.18 This is my first time making the release notes so please give it an extra once over!

brson mentioned this pull request May 31, 2017
[beta] Updated releases notes for 1.18 #42338
Merged

Updated releases notes for 1.18
02c0d3c

brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 1, 2017

bors added a commit that referenced this pull request Jun 3, 2017
Auto merge of#42338- brson:beta-next, r=brson
db91aaf
[beta] Updated releases notes for 1.18 - #41953

bors added a commit that referenced this pull request Jun 3, 2017
Auto merge of#41953- Aaronepower:patch-1, r=brson
14526a3
Updated releases notes for 1.18 This is my first time making the release notes so please give it an extra once over!

bors merged commit 02c0d3c into rust-lang:masterJun 3, 2017

Uh oh!

Uh oh!

Conversation

XAMPPRocky commented May 12, 2017

Uh oh!

rust-highfive commented May 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aturon commented May 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented May 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brson commented May 12, 2017

Uh oh!

XAMPPRocky commented May 12, 2017

Uh oh!

leonardo-m commented May 12, 2017

Uh oh!

XAMPPRocky commented May 12, 2017

Uh oh!

leonardo-m commented May 12, 2017

Uh oh!

eddyb commented May 12, 2017

Uh oh!

XAMPPRocky commented May 12, 2017

Uh oh!

Mark-Simulacrum commented May 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aidanhs commented May 18, 2017

Uh oh!

brson commented May 22, 2017

Uh oh!

sfackler commented May 22, 2017

Uh oh!

XAMPPRocky commented May 24, 2017

Uh oh!

brson commented May 25, 2017

Uh oh!

brson commented May 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brson commented May 31, 2017

Uh oh!

brson commented May 31, 2017

Uh oh!

bors commented May 31, 2017

Uh oh!

brson commented May 31, 2017

Uh oh!

brson commented May 31, 2017