Skip to content

Update RLS to solve serious crash - #41969

Merged
bors merged 1 commit into
rust-lang:masterfrom
Enet4:update-rls-313
May 14, 2017
Merged

Update RLS to solve serious crash#41969
bors merged 1 commit into
rust-lang:masterfrom
Enet4:update-rls-313

Conversation

@Enet4

@Enet4Enet4 commented May 13, 2017

Copy link
Copy Markdown
Contributor

As a follow-up to rust-lang/rls#312, this PR contains the fix to the latest experienced RLS crashes, which should hopefully reach the nightly release as soon as possible.

@rust-highfive

rust-highfive commented May 13, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@petrochenkov

petrochenkov commented May 13, 2017

Copy link
Copy Markdown
Contributor

@bors r+
Thanks!

@bors

bors commented May 13, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit eef6662 has been approved by petrochenkov

@Mark-Simulacrum

Mark-Simulacrum commented May 13, 2017

Copy link
Copy Markdown
Member

@bors p=1

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 13, 2017
@frewsxcv
Rollup merge ofrust-lang#41969- Enet4:update-rls-313, r=petrochenkov
9d65556
Update RLS to solve serious crash
As a follow-up to rust-lang/rls#312, this PR contains the fix to the latest experienced RLS crashes, which should hopefully reach the nightly release as soon as possible.
@frewsxcvfrewsxcv mentioned this pull request May 13, 2017
Closed
@bors

bors commented May 13, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit eef6662 with merge 884fd4c...

@Mark-Simulacrum

Mark-Simulacrum commented May 13, 2017

Copy link
Copy Markdown
Member

@bors retry

Prioritizing rollup that contains this

bors added a commit that referenced this pull request May 13, 2017
@bors
Auto merge of#41972- frewsxcv:rollup, r=frewsxcv
2a03443
Rollup of 5 pull requests
- Successful merges: #41826, #41919, #41946, #41967, #41969
- Failed merges: #41939
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 13, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#41969- Enet4:update-rls-313, r=petrochenkov
f5683fa
Update RLS to solve serious crash
As a follow-up to rust-lang/rls#312, this PR contains the fix to the latest experienced RLS crashes, which should hopefully reach the nightly release as soon as possible.
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 13, 2017
Closed
@nrc

nrc commented May 13, 2017

Copy link
Copy Markdown
Member

@bors r-

There has been another update to LSP types (to 0.10), so this submodule update is out of date now.

@Enet4

Enet4 commented May 13, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@nrc I have pulled the latest changes to the PR. Can we try again now? :)

@Mark-Simulacrum

Mark-Simulacrum commented May 14, 2017

Copy link
Copy Markdown
Member

Could you squash commits?

@Enet4
Update rls submodule with important fixes
b868434
- Updates ls_types to "0.10.0", which prevents RLS crashes
@Enet4

Enet4 commented May 14, 2017

Copy link
Copy Markdown
ContributorAuthor

@Mark-Simulacrum Commits were squashed (I don't squash commits very often, but hopefully everything is in order).

@Mark-Simulacrum

Mark-Simulacrum commented May 14, 2017

Copy link
Copy Markdown
Member

Thanks!

@bors r+

@bors

bors commented May 14, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit b868434 has been approved by Mark-Simulacrum

@bors

bors commented May 14, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b868434 with merge e30ddb2...

@bors

bors commented May 14, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@chetgurevitch

chetgurevitch commented May 14, 2017

Copy link
Copy Markdown

Build failed due to a seemingly random(?) server error with crates.io.

@Mark-Simulacrum

Mark-Simulacrum commented May 14, 2017

Copy link
Copy Markdown
Member

@bors retry

@Mark-Simulacrum

Mark-Simulacrum commented May 14, 2017

Copy link
Copy Markdown
Member

Previous appveyor failure, #41545. Logged.

[01:28:26] failed to get 200 response from `https://crates.io/api/v1/crates/utf8-ranges/0.1.3/download`, got 500

@FaultyRAMFaultyRAM mentioned this pull request May 14, 2017
Closed
@bors

bors commented May 14, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b868434 with merge 9f15631...

bors added a commit that referenced this pull request May 14, 2017
@bors
Auto merge of#41969- Enet4:update-rls-313, r=Mark-Simulacrum
9f15631
Update RLS to solve serious crash
As a follow-up to rust-lang/rls#312, this PR contains the fix to the latest experienced RLS crashes, which should hopefully reach the nightly release as soon as possible.
@nrc

nrc commented May 14, 2017

Copy link
Copy Markdown
Member

Thanks @Enet4 !

@bors

bors commented May 14, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 9f15631 to master...

@bors
bors merged commit b868434 into rust-lang:masterMay 14, 2017
@cmyrcmyr mentioned this pull request May 14, 2017
Closed
@Enet4
Enet4 deleted the update-rls-313 branch May 24, 2017 16:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Enet4@rust-highfive@petrochenkov@bors@Mark-Simulacrum@nrc@chetgurevitch@alexcrichton