Uh oh!
There was an error while loading. Please reload this page.
Pass static crt to llvm cmake configuration - #41975
Conversation
rust-highfive
commented
May 13, 2017
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
liranringel
commented
May 13, 2017
Mark-Simulacrum
commented
May 13, 2017
Are the dependency updates necessary, or unrelated? |
liranringel
commented
May 13, 2017
@Mark-Simulacrum they are necessary. See rust-lang/cc-rs#159 and rust-lang/cmake-rs#31 |
Mark-Simulacrum
commented
May 13, 2017
Sounds good. Just making sure. |
alexcrichton
commented
May 13, 2017
@bors: r+ Thanks! |
bors
commented
May 13, 2017
📌 Commit 1163f2c has been approved by |
…-cmake-config, r=alexcrichton Pass static crt to llvm cmake configuration Solves rust-lang#40246
…-cmake-config, r=alexcrichton Pass static crt to llvm cmake configuration Solves rust-lang#40246
Solves #40246