Skip to content

Fix regression in macro_rules! name matching - #42005

Merged
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:fix_macro_regression
May 16, 2017
Merged

Fix regression in macro_rules! name matching#42005
bors merged 1 commit into
rust-lang:masterfrom
jseyfried:fix_macro_regression

Conversation

@jseyfried

@jseyfriedjseyfried commented May 15, 2017

Copy link
Copy Markdown
Contributor

Fixes#41803.
r? @nrc

@jseyfriedjseyfried added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 15, 2017
@jseyfriedjseyfried mentioned this pull request May 15, 2017
Closed
@carols10centscarols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2017
@jseyfriedjseyfried mentioned this pull request May 15, 2017
Closed
@nrc

nrc commented May 16, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented May 16, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9f4e1e1 has been approved by nrc

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 16, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42005- jseyfried:fix_macro_regression, r=nrc
747f7d2
Fix regression in `macro_rules!` name matching
Fixesrust-lang#41803.
r? @nrc
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 16, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 16, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42005- jseyfried:fix_macro_regression, r=nrc
6b4f3a7
Fix regression in `macro_rules!` name matching
Fixesrust-lang#41803.
r? @nrc
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 16, 2017
Merged
@arielb1arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2017
bors added a commit that referenced this pull request May 16, 2017
@bors
Auto merge of#42038- Mark-Simulacrum:rollup, r=Mark-Simulacrum
0f68728
Rollup of 8 pull requests
- Successful merges: #41489, #41982, #41994, #41995, #42001, #42005, #42011, #42028
- Failed merges:
@bors
bors merged commit 9f4e1e1 into rust-lang:masterMay 16, 2017
@jseyfried
jseyfried deleted the fix_macro_regression branch May 17, 2017 03:50
@michaelwoerister

michaelwoerister commented May 18, 2017

Copy link
Copy Markdown
Member

Discussed in the compiler team meeting: backporting seems like a good idea.

@michaelwoeristermichaelwoerister added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels May 18, 2017
@brsonbrson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 1, 2017
@alexcrichtonalexcrichton mentioned this pull request Jun 1, 2017
Merged
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 1, 2017
bors added a commit that referenced this pull request Jun 1, 2017
@bors
Auto merge of#42364- alexcrichton:beta-next, r=brson
38eab2e
[beta] Fix regression in `macro_rules!` name matching.
This is a backport of #42005
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrcnrc

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jseyfried@nrc@bors@michaelwoerister@brson@carols10cents@arielb1