Skip to content

Remove FusedIterator implementation of iter::Scan - #42014

Merged
bors merged 1 commit into
rust-lang:masterfrom
tbu-:pr_scan_not_fused
May 26, 2017
Merged

Remove FusedIterator implementation of iter::Scan#42014
bors merged 1 commit into
rust-lang:masterfrom
tbu-:pr_scan_not_fused

Conversation

@tbu-

@tbu-tbu- commented May 15, 2017

Copy link
Copy Markdown
Contributor

Fixes#41964.

This is a breaking change.

@rust-highfive

rust-highfive commented May 15, 2017

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@tbu-

tbu- commented May 15, 2017

Copy link
Copy Markdown
ContributorAuthor

I'd like to know whether the current Scan behavior is the intended one.

@kennytm

kennytm commented May 15, 2017

Copy link
Copy Markdown
Member

There should be a test case?

@tbu-

tbu- commented May 15, 2017

Copy link
Copy Markdown
ContributorAuthor

Do you mean this PR or the scan function in general?

I don't think you need to test the absence of the FusedIterator implementation. If you mean the scan function in general: The test case does not exercise this behavior, it's still unclear after the doc example.

@kennytm

kennytm commented May 15, 2017

Copy link
Copy Markdown
Member

@tbu- Probably use the expected behavior of #41964 as the test case

@arielb1

arielb1 commented May 16, 2017

Copy link
Copy Markdown
Contributor

Thanks for the PR @tbu-! @brson (or someone else) will be reviewing your PR soon.

@arielb1arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2017
@Mark-Simulacrum

Mark-Simulacrum commented May 20, 2017

Copy link
Copy Markdown
Member

@brson This looks like it needs a review. Could you take a look?

@frewsxcvfrewsxcv added the T-libs-api [DEPRECATED; DO NOT USE] label May 22, 2017
@alexcrichton

alexcrichton commented May 25, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented May 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit a7d91ef has been approved by alexcrichton

@alexcrichtonalexcrichton added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2017
@bors

bors commented May 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a7d91ef with merge 5280d66...

@bors

bors commented May 25, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented May 25, 2017

Copy link
Copy Markdown
Member

@bors: retry

@frewsxcvfrewsxcv mentioned this pull request May 26, 2017
Closed
@bors

bors commented May 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a7d91ef with merge 11d8b09...

@bors

bors commented May 26, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@kennytm

kennytm commented May 26, 2017

Copy link
Copy Markdown
Member

Emscripten timed out after 3 hours.

@Mark-Simulacrum

Mark-Simulacrum commented May 26, 2017

Copy link
Copy Markdown
Member

@bors retry

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 26, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42014- tbu-:pr_scan_not_fused, r=alexcrichton
babc2a0
Remove `FusedIterator` implementation of `iter::Scan`
Fixesrust-lang#41964.
This is a breaking change.
@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 26, 2017
Closed
@bors

bors commented May 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a7d91ef with merge c732446...

bors added a commit that referenced this pull request May 26, 2017
@bors
Auto merge of#42014- tbu-:pr_scan_not_fused, r=alexcrichton
c732446
Remove `FusedIterator` implementation of `iter::Scan`
Fixes#41964.
This is a breaking change.
@bors

bors commented May 26, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c732446 to master...

@bors
bors merged commit a7d91ef into rust-lang:masterMay 26, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brsonbrson

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@tbu-@rust-highfive@kennytm@arielb1@Mark-Simulacrum@alexcrichton@bors@brson@frewsxcv