Skip to content

add thiscall calling convention support - #42058

Merged
bors merged 1 commit into
rust-lang:masterfrom
froydnj:thiscall-support
May 26, 2017
Merged

add thiscall calling convention support#42058
bors merged 1 commit into
rust-lang:masterfrom
froydnj:thiscall-support

Conversation

@froydnj

@froydnjfroydnj commented May 17, 2017

Copy link
Copy Markdown
Contributor

This support is needed for bindgen to work well on 32-bit Windows, and also enables people to begin experimenting with C++ FFI support on that platform.

Fixes#42044.

@rust-highfive

rust-highfive commented May 17, 2017

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhsaidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2017
@aidanhs

aidanhs commented May 18, 2017

Copy link
Copy Markdown
Contributor

Thanks for the PR @froydnj, we'll make sure it gets reviewed by @pnkfelix or another reviewer soon!

@carols10cents

carols10cents commented May 22, 2017

Copy link
Copy Markdown
Member

ping @pnkfelix, pinging you on irc too!

@arielb1arielb1 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 23, 2017
@arielb1

arielb1 commented May 23, 2017

Copy link
Copy Markdown
Contributor

r? @japaric

Actually, I might go and review this myself tomorrow.

@sophiajtsophiajt mentioned this pull request May 23, 2017
Closed
nikomatsakis
nikomatsakis requested changes May 24, 2017
View reviewed changes

@nikomatsakisnikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with some text in the unstable book, bonus points for opening an issue, but I can do that later

Comment threadsrc/doc/unstable-book/src/language-features/abi-thiscall.md Outdated

@nikomatsakisnikomatsakisMay 24, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a tracking issue for this? I think it'd be fine to have one tracking issue covering all the various unstable ABIs. It'd also be nice to actually put a few words in there about what the purpose of this ABI is. If we're going to have a book we might as well write something in it. =)

@froydnjfroydnj mentioned this pull request May 24, 2017
Closed
@froydnj
add thiscall calling convention support
9a2e245
This support is needed for bindgen to work well on 32-bit Windows, and
also enables people to begin experimenting with C++ FFI support on that
platform.
Fixesrust-lang#42044.
@froydnj

froydnj commented May 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review! Added a bit of text to the book, along with a link to the tracking issue.

r? @nikomatsakis

@nikomatsakis

nikomatsakis commented May 25, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9a2e245 has been approved by nikomatsakis

@bors

bors commented May 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9a2e245 with merge 35ac065...

@bors

bors commented May 25, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented May 25, 2017

Copy link
Copy Markdown
Member

@bors: retry

@bors

bors commented May 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9a2e245 with merge 2db17c8...

bors added a commit that referenced this pull request May 26, 2017
@bors
Auto merge of#42058- froydnj:thiscall-support, r=nikomatsakis
2db17c8
add thiscall calling convention support
This support is needed for bindgen to work well on 32-bit Windows, and also enables people to begin experimenting with C++ FFI support on that platform.
Fixes#42044.
@bors

bors commented May 26, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 2db17c8 to master...

@bors
bors merged commit 9a2e245 into rust-lang:masterMay 26, 2017
@borsbors mentioned this pull request May 26, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis approved these changes

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@froydnj@rust-highfive@aidanhs@carols10cents@arielb1@nikomatsakis@bors@alexcrichton@pnkfelix