Uh oh!
There was an error while loading. Please reload this page.
Fix: "warning: redundant linker flag specified for library ole32" - #42113
Conversation
llvm-config seems to output this library name correctly now, removing the need for the hack in "librustc_llvm/build.rs".
rust-highfive
commented
May 20, 2017
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
petrochenkov
commented
May 20, 2017
Ha, I was mildly annoyed by this message as well, thanks for fixing. |
bors
commented
May 20, 2017
📌 Commit 2e0043a has been approved by |
bors
commented
May 20, 2017
⌛ Testing commit 2e0043a with merge f4e4ada... |
bors
commented
May 20, 2017
💔 Test failed - status-appveyor |
Mark-Simulacrum
commented
May 20, 2017
@bors retry We appear to have just failed to compile rustc: |
bors
commented
May 20, 2017
Fix: "warning: redundant linker flag specified for library `ole32`" llvm-config seems to output this library name correctly now, removing the need for the hack in "librustc_llvm/build.rs".
bors
commented
May 20, 2017
☀️ Test successful - status-appveyor, status-travis |
llvm-config seems to output this library name correctly now, removing
the need for the hack in "librustc_llvm/build.rs".