Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Fix names of items in cross crate reexported modules - #42145
Merged
Conversation
For renamed reexports the new name should be used.
rust-highfive
commented
May 22, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
steveklabnik
commented
May 22, 2017
Contributor
Nice, thank you! @bors: r+ rollup |
bors
commented
May 22, 2017
Collaborator
📌 Commit 0cb6a1f has been approved by |
bors
commented
May 22, 2017
Collaborator
⌛ Testing commit 0cb6a1f with merge 97b779f... |
steveklabnik
commented
May 22, 2017
Contributor
@bors: rollup- (Actually maybe this is best not a rollup) |
bors
commented
May 22, 2017
Collaborator
💔 Test failed - status-appveyor |
Mark-Simulacrum
commented
May 22, 2017
Member
@bors retry
|
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
May 23, 2017
…teveklabnik rustdoc: Fix names of items in cross crate reexported modules For renamed reexports the new name should be used. An example of this (as pointed out in rust-lang#27741 (comment)) is two instances of `StepBy` in [`std::iter`](https://doc.rust-lang.org/nightly/std/iter/index.html#structs). [`core::iter`](https://doc.rust-lang.org/nightly/core/iter/index.html#structs) is correct. Fixesrust-lang#37608
bors added a commit
that referenced
this pull request
May 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For renamed reexports the new name should be used.
An example of this (as pointed out in #27741 (comment)) is two instances of
StepByinstd::iter.core::iteris correct.Fixes#37608