Convert Intos to Froms. by ollie27 · Pull Request #42227 · rust-lang/rust

ollie27 · 2017-05-25T20:35:59Z

This is a resubmission of #42129 without impl<T> From<Vec<T>> for Box<[T]>.

rust-highfive · 2017-05-25T20:36:11Z

r? @BurntSushi

(rust_highfive has picked a reviewer for you, use r? to override)

BurntSushi · 2017-05-25T20:40:40Z

As with #42129, I'd still feel better with a crater run.

Mark-Simulacrum · 2017-06-04T01:01:40Z

Infra team is experimenting....

@bors try

bors · 2017-06-04T01:01:51Z

⌛ Trying commit 30bbcef with merge 8da3914...

Convert Intos to Froms. This is a resubmission of #42129 without `impl<T> From<Vec<T>> for Box<[T]>`.

bors · 2017-06-04T01:10:11Z

💔 Test failed - status-travis

frewsxcv · 2017-06-04T01:22:45Z

@bors retry

travis cancelled one of the builds

bors · 2017-06-04T01:22:53Z

⌛ Trying commit 30bbcef with merge 98629a9...

bors · 2017-06-04T01:28:53Z

💔 Test failed - status-travis

Mark-Simulacrum · 2017-06-04T01:29:17Z

Intentionally canceled build -- we need to land another PR before try builds make sense.

Mark-Simulacrum · 2017-06-04T19:02:17Z

@bors try

Getting artifacts for cargobomb.

Mark-Simulacrum · 2017-06-04T19:03:20Z

Oh, I guess it needs to retry try?

@bors retry

bors · 2017-06-04T19:03:29Z

⌛ Trying commit 30bbcef with merge 0964ee3...

frewsxcv · 2017-06-05T13:04:17Z

@bors retry

brson · 2017-06-05T21:22:55Z

I've deployed a new build of crater. Will try this one.

brson · 2017-06-05T21:28:40Z

Building toolchains

brson · 2017-06-06T00:36:18Z

Messed up the previous commands. Here are the new jobs:

brson · 2017-06-06T16:40:20Z

Still fixing crater:

arielb1 · 2017-06-13T20:39:17Z

Isn't @aturon on vacation right now? I think this PR has been open long enough that we'll just wait for him for the final signoff.

bors · 2017-06-15T15:07:03Z

☔ The latest upstream changes (presumably #42648) made this pull request unmergeable. Please resolve the merge conflicts.

clarfonthey · 2017-06-16T01:15:32Z

Small nudge to point out that this can add back the Vec implementation now that alloc and collections are merged.

ollie27 · 2017-06-17T16:06:13Z

Rebased. I've submitted the Vec impl separately (#42717) to avoid holding up this PR any longer.

Convert `Into<Box<[T]>> for Vec<T>` into `From<Vec<T>> for Box<[T]>` As the `collections` crate has been merged into `alloc` in #42648 this impl is now possible. This is the final part of #42129 missing from #42227.

bors · 2017-06-20T17:41:57Z

☔ The latest upstream changes (presumably #42716) made this pull request unmergeable. Please resolve the merge conflicts.

Convert `Into<Box<[T]>> for Vec<T>` into `From<Vec<T>> for Box<[T]>` As the `collections` crate has been merged into `alloc` in rust-lang#42648 this impl is now possible. This is the final part of rust-lang#42129 missing from rust-lang#42227.

Mark-Simulacrum · 2017-06-24T23:32:42Z

@aturon I think this is ready for merge but not quite sure...

aidanhs · 2017-06-28T18:22:37Z

I've pinged @aturon, but I suspect he's not going to get to this until next week.

aturon · 2017-07-03T17:58:51Z

@bors: r+ rollup

Thanks!

bors · 2017-07-03T17:58:52Z

📌 Commit 0d885ef has been approved by aturon

Convert Intos to Froms. This is a resubmission of rust-lang#42129 without `impl<T> From<Vec<T>> for Box<[T]>`.

Rollup of 8 pull requests - Successful merges: #42227, #42836, #42975, #42994, #43041, #43042, #43043, #43045 - Failed merges:

rust-highfive assigned BurntSushi May 25, 2017

ollie27 mentioned this pull request May 25, 2017
Convert Intos to Froms. #42129
Closed

BurntSushi added S-waiting-on-crater Status: Waiting on a crater run to be completed. T-libs-api [DEPRECATED; DO NOT USE] labels May 25, 2017

shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 27, 2017

aidanhs added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 1, 2017

bors added a commit that referenced this pull request Jun 4, 2017
Auto merge of#42227- ollie27:into_to_from, r=<try>
8da3914
Convert Intos to Froms. This is a resubmission of #42129 without `impl<T> From<Vec<T>> for Box<[T]>`.

Mark-Simulacrum closed this Jun 5, 2017

Mark-Simulacrum reopened this Jun 5, 2017

arielb1 removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jun 6, 2017

arielb1 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 13, 2017

ollie27 force-pushed the into_to_from branch from 6089fc0 to 6a8a37eCompare June 17, 2017 16:05

ollie27 mentioned this pull request Jun 17, 2017
Convert Into<Box<[T]>> for Vec<T> into From<Vec<T>> for Box<[T]>#42717
Merged

arielb1 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2017

Clar Charrand others added 2 commits June 21, 2017 01:18

Convert Intos to Froms.
5a97036

Update version numbers for From impls
0d885ef

ollie27 force-pushed the into_to_from branch from 6a8a37e to 0d885efCompare June 21, 2017 00:20

Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2017

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2017
Rollup merge ofrust-lang#42227- ollie27:into_to_from, r=aturon
0f8998d
Convert Intos to Froms. This is a resubmission of rust-lang#42129 without `impl<T> From<Vec<T>> for Box<[T]>`.

Mark-Simulacrum mentioned this pull request Jul 4, 2017
Rollup of 7 pull requests #43047
Closed

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2017
Rollup merge ofrust-lang#42227- ollie27:into_to_from, r=aturon
32cbbff
Convert Intos to Froms. This is a resubmission of rust-lang#42129 without `impl<T> From<Vec<T>> for Box<[T]>`.

Mark-Simulacrum mentioned this pull request Jul 4, 2017
Rollup of 8 pull requests #43051
Merged

bors added a commit that referenced this pull request Jul 4, 2017
Auto merge of#43051- Mark-Simulacrum:rollup, r=Mark-Simulacrum
2fbba5b
Rollup of 8 pull requests - Successful merges: #42227, #42836, #42975, #42994, #43041, #43042, #43043, #43045 - Failed merges:

bors merged commit 0d885ef into rust-lang:masterJul 4, 2017

ollie27 deleted the into_to_from branch July 4, 2017 19:29

Uh oh!

Uh oh!

Conversation

ollie27 commented May 25, 2017

Uh oh!

rust-highfive commented May 25, 2017

Uh oh!

BurntSushi commented May 25, 2017

Uh oh!

Mark-Simulacrum commented Jun 4, 2017

Uh oh!

bors commented Jun 4, 2017

Uh oh!

bors commented Jun 4, 2017

Uh oh!

frewsxcv commented Jun 4, 2017

Uh oh!

bors commented Jun 4, 2017

Uh oh!

bors commented Jun 4, 2017

Uh oh!

Mark-Simulacrum commented Jun 4, 2017

Uh oh!

Mark-Simulacrum commented Jun 4, 2017

Uh oh!

Mark-Simulacrum commented Jun 4, 2017

Uh oh!

bors commented Jun 4, 2017

Uh oh!

frewsxcv commented Jun 5, 2017

Uh oh!

brson commented Jun 5, 2017

Uh oh!

brson commented Jun 5, 2017

Uh oh!

brson commented Jun 6, 2017

Uh oh!

brson commented Jun 6, 2017

Uh oh!

arielb1 commented Jun 13, 2017

Uh oh!

bors commented Jun 15, 2017

Uh oh!

clarfonthey commented Jun 16, 2017

Uh oh!

ollie27 commented Jun 17, 2017

Uh oh!

bors commented Jun 20, 2017

Uh oh!

Mark-Simulacrum commented Jun 24, 2017

Uh oh!

aidanhs commented Jun 28, 2017

Uh oh!

aturon commented Jul 3, 2017

Uh oh!

bors commented Jul 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants