Skip to content

Update documentation for indexing/slicing methods - #42236

Merged
bors merged 1 commit into
rust-lang:masterfrom
citizen428:docs/unchecked-indexing-slicing
May 26, 2017
Merged

Update documentation for indexing/slicing methods#42236
bors merged 1 commit into
rust-lang:masterfrom
citizen428:docs/unchecked-indexing-slicing

Conversation

@citizen428

@citizen428citizen428 commented May 26, 2017

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented May 26, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez
GuillaumeGomez reviewed May 26, 2017
View reviewed changes
Comment threadsrc/libcollections/slice.rs Outdated

@GuillaumeGomezGuillaumeGomezMay 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this removal?

@citizen428citizen428May 26, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sausage fingers...

GuillaumeGomez
GuillaumeGomez reviewed May 26, 2017
View reviewed changes
Comment threadsrc/libcollections/str.rs Outdated

@GuillaumeGomezGuillaumeGomezMay 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line before the new sentence.

GuillaumeGomez
GuillaumeGomez reviewed May 26, 2017
View reviewed changes
Comment threadsrc/libcollections/str.rs Outdated

@GuillaumeGomezGuillaumeGomezMay 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line before the new sentence.

GuillaumeGomez
GuillaumeGomez reviewed May 26, 2017
View reviewed changes
Comment threadsrc/libcollections/slice.rs Outdated

@GuillaumeGomezGuillaumeGomezMay 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line before the new sentence.

GuillaumeGomez
GuillaumeGomez reviewed May 26, 2017
View reviewed changes
Comment threadsrc/libcollections/slice.rs Outdated

@GuillaumeGomezGuillaumeGomezMay 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line before the new sentence.

@GuillaumeGomez

GuillaumeGomez commented May 26, 2017

Copy link
Copy Markdown
Member

All good, just a few nits.

@citizen428
citizen428force-pushed the docs/unchecked-indexing-slicing branch from 3d5ea15 to a6d455dCompareMay 26, 2017 08:48
@citizen428

citizen428 commented May 26, 2017

Copy link
Copy Markdown
ContributorAuthor

@GuillaumeGomez Thanks for the feedback, just updated the PR.

@citizen428
citizen428force-pushed the docs/unchecked-indexing-slicing branch from a6d455d to bbf1dc4CompareMay 26, 2017 08:49
@GuillaumeGomez

GuillaumeGomez commented May 26, 2017

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented May 26, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit bbf1dc4 has been approved by GuillaumeGomez

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 26, 2017
@frewsxcv
Rollup merge ofrust-lang#42236- citizen428:docs/unchecked-indexing-…
1a35f2f
…slicing, r=GuillaumeGomez
Update documentation for indexing/slicing methods
See rust-lang#39911
r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 26, 2017
@frewsxcv
Rollup merge ofrust-lang#42236- citizen428:docs/unchecked-indexing-…
854196a
…slicing, r=GuillaumeGomez
Update documentation for indexing/slicing methods
See rust-lang#39911
r? @steveklabnik
@frewsxcvfrewsxcv mentioned this pull request May 26, 2017
Merged
bors added a commit that referenced this pull request May 26, 2017
@bors
Auto merge of#42245- frewsxcv:rollup, r=frewsxcv
256e497
Rollup of 7 pull requests
- Successful merges: #42169, #42215, #42216, #42224, #42230, #42236, #42241
- Failed merges:
@bors
bors merged commit bbf1dc4 into rust-lang:masterMay 26, 2017
@bors

bors commented May 26, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #42245) made this pull request unmergeable. Please resolve the merge conflicts.

@citizen428
citizen428 deleted the docs/unchecked-indexing-slicing branch June 5, 2017 13:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez left review comments

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@citizen428@rust-highfive@GuillaumeGomez@bors@steveklabnik