Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #42336
Merged
Merged
Conversation
This makes the size_hint from things like `take` more precise.
Clarify docs on implementing Into. This was suggested by @dtolnay in rust-lang#40380. This explicitly clarifies in what circumstances you should implement `Into` instead of `From`.
…matsakis Explain why a closure is `FnOnce` in closure errors. Issue: rust-lang#42065@nikomatsakis Am I going the right direction with this? ~~I am stuck in a few bits:~~ ~~1. How to trace the code to get the upvar instead of the original variable's span?~~ ~~2. How to find the node id of the upvar where the move occured?~~
…komatsakis Clarify the docs for align_of and its variants It's okay to have unaligned raw pointers and then use `ptr::write_unaligned` and `ptr::read_unaligned`. However, using unaligned `&T` and `&mut T` would be undefined behavior. The current documentation seems to indicate that everything has to be aligned, but in reality only references do. This PR changes the text of docs accordingly. r? @sfackler
…ta, r=nikomatsakis Remove --crate-type=metadata deprecation warning Fixesrust-lang#38640
…crichton RangeFrom should have an infinite size_hint Before, ```rust (0..).take(4).size_hint() == (0, Some(4)) ``` With this change, ```rust (0..).take(4).size_hint() == (4, Some(4)) ```
fix links to "module-level documentation" see rust-lang#42267
…chenkov Parse macros named "default" correctly. Fixesrust-lang#42292.
rust-highfive
commented
May 31, 2017
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
May 31, 2017
MemberAuthor
@bors r+ p=10 |
bors
commented
May 31, 2017
Collaborator
📌 Commit 7f286a8 has been approved by |
bors
commented
May 31, 2017
Collaborator
bors added a commit
that referenced
this pull request
May 31, 2017
bors
commented
May 31, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FnOncein closure errors. #42196, Clarify the docs for align_of and its variants #42252, Remove --crate-type=metadata deprecation warning #42277, RangeFrom should have an infinite size_hint #42315, fix links to "module-level documentation" #42329, Parse macros named "default" correctly. #42330