Re-implement float min/max in rust by nagisa · Pull Request #42430 · rust-lang/rust

nagisa · 2017-06-04T18:46:57Z

This also adds the relevant implementations into libcore.

See #42423

rust-highfive · 2017-06-04T18:46:59Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

kennytm · 2017-06-04T18:50:48Z

You mean self > other here?

self < other so self is that minimal one, seems reasonable.

The other one is/was wrong. I’ll just write down some tests.

@bombless 😂
I was commenting on 896a41a9, nagisa fixed it in the new commit b9ed1c6, GitHub somehow messed up and used the old comment referring to the latest change.

natboehm · 2017-06-05T15:30:51Z

[00:02:15] tidy error: Unstable library feature 'core_float_min_max' needs to have a section within the 'library features' section of The Unstable Book
[00:02:15] some tidy checks failed

Tidy is failing because this isn't mentioned in the book.

carols10cents · 2017-06-12T12:25:08Z

Aturon's on vacation this week, so let's try...

r? @alexcrichton

alexcrichton · 2017-06-13T02:28:50Z

Since these are stable in the standard library I think it's fine to go ahead and stabilize them in libcore itself, this is just moving the implementation down a layer where we could

alexcrichton · 2017-06-13T02:29:49Z

FWIW the musl implementation is quite different, it's not clear to me that these are the same?

The only difference between the implementations is handling of the signed zero. IEEE 754 allows to ignore the signed-ness of zero here and, if 0.0 is compared to -0.0, to return either one.
Even the C99 standard does not mention signed zeroes in the annex referenced by musl. It quite literally paraphrases the IEEE 754 and provides an example implementation which matches (with small differences) the one provided here.

Ok seems reasonable!

See rust-lang#42423

alexcrichton · 2017-06-16T17:45:13Z

@bors: r+

bors · 2017-06-16T17:45:15Z

📌 Commit ba6cf1d has been approved by alexcrichton

bors · 2017-06-16T17:52:17Z

⌛ Testing commit ba6cf1d with merge fe7227f...

Re-implement float min/max in rust This also adds the relevant implementations into libcore. See #42423

bors · 2017-06-16T20:34:54Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing fe7227f to master...

rust-highfive assigned aturon Jun 4, 2017

kennytm reviewed Jun 4, 2017
View reviewed changes

nagisa force-pushed the core-float branch 2 times, most recently from 7544f5c to 540373dCompare June 5, 2017 12:54

carols10cents added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 5, 2017

nagisa force-pushed the core-float branch 2 times, most recently from 333bf76 to ef2b445Compare June 5, 2017 15:51

arielb1 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 6, 2017

rust-highfive assigned alexcrichton and unassigned aturon Jun 12, 2017

alexcrichton reviewed Jun 13, 2017
View reviewed changes

alexcrichton added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2017

nagisa force-pushed the core-float branch 2 times, most recently from bd0be22 to b1dadc8Compare June 14, 2017 15:26

Re-implement float min/max in rust
ba6cf1d
See rust-lang#42423

nagisa force-pushed the core-float branch from b1dadc8 to ba6cf1dCompare June 14, 2017 18:59

bors added a commit that referenced this pull request Jun 16, 2017
Auto merge of#42430- nagisa:core-float, r=alexcrichton
fe7227f
Re-implement float min/max in rust This also adds the relevant implementations into libcore. See #42423

nagisa added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 16, 2017

bors merged commit ba6cf1d into rust-lang:masterJun 16, 2017

bors mentioned this pull request Jun 16, 2017
Add cast function to primitive integers #42456
Closed

sunfishcode mentioned this pull request Oct 18, 2017
Document NaN propagation semantics bytecodealliance/cranelift#20
Closed

est31 mentioned this pull request Feb 10, 2020
SNaN and QNaN are swapped on mipsel and mips64el compared to most other architectures #68925
Open

Uh oh!

Uh oh!

Conversation

nagisa commented Jun 4, 2017

Uh oh!

rust-highfive commented Jun 4, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

natboehm commented Jun 5, 2017

Uh oh!

carols10cents commented Jun 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Jun 16, 2017

Uh oh!

bors commented Jun 16, 2017

Uh oh!

bors commented Jun 16, 2017

Uh oh!

bors commented Jun 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants