Skip to content

rustc: T: 'empty always holds for all types. - #42482

Merged
bors merged 1 commit into
rust-lang:masterfrom
eddyb:issue-42467
Jun 7, 2017
Merged

rustc: T: 'empty always holds for all types.#42482
bors merged 1 commit into
rust-lang:masterfrom
eddyb:issue-42467

Conversation

@eddyb

@eddybeddyb commented Jun 6, 2017

Copy link
Copy Markdown
Contributor

Fixes#42467 by special-casing ReEmpty to always hold, even for parameters.
The reason this is the case is that ReEmpty is the result of inferring a region variable with no constraints attached to it, so there is no lifetime a type would contain which would be strictly shorter.

r? @nikomatsakis

@eddybeddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 6, 2017
@eddyb
eddyb requested a review from nikomatsakisJune 6, 2017 16:54
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 6, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit ec7195f has been approved by nikomatsakis

@bors

bors commented Jun 7, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ec7195f with merge 37b1f6c...

bors added a commit that referenced this pull request Jun 7, 2017
rustc: T: 'empty always holds for all types.
Fixes#42467 by special-casing `ReEmpty` to always hold, even for parameters.
The reason this is the case is that `ReEmpty` is the result of inferring a region variable with no constraints attached to it, so there is no lifetime a type would contain which would be strictly shorter.
r? @nikomatsakis
@bors

bors commented Jun 7, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 37b1f6c to master...

@bors
bors merged commit ec7195f into rust-lang:masterJun 7, 2017
@eddyb
eddyb deleted the issue-42467 branch June 7, 2017 12:34
@brsonbrson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 12, 2017
@brsonbrson mentioned this pull request Jun 12, 2017
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 13, 2017
bors added a commit that referenced this pull request Jun 15, 2017
Beta next
- #42521
- #42512
- #42482
- #42481
- #42480
r? @nikomatsakis remember to untag 'beta-nominated' on linked issues
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@eddyb@nikomatsakis@bors@brson