Uh oh!
There was an error while loading. Please reload this page.
bump 0.5 => 0.6, redirect some URLs in docs. - #4249
Merged
Merged
Conversation
catamorphism added a commit
that referenced
this pull request
Dec 23, 2012
bump 0.5 => 0.6, redirect some URLs in docs.
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Apr 9, 2025
…t-provenance test-cargo-miri: permissive provenance should not be needed any more
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
In an attempt to fixrust-lang#6052 and rust-lang#4249 this attempts to detect if rustfmt is a rustup proxy which isn't installed, and reports the error message to the user for them to fix. In theory this ought to be memoised but for now it'll do as-is. Future work might be to ask the user if they would like us to trigger the installation (if possible). Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
7055: Install rustfmt if needed during formatting request r=matklad a=kinnison In order to fixrust-lang#6052 and to fixrust-lang#4249 this PR installs `rustfmt` using `rustup` if `rustfmt --help` fails. In theory we ought to memoise the attempts (both the `--help` and the installation) so that we don't keep retrying something which will fail (e.g. if nightly is missing rustfmt), but this is a first-pass for opinions. In order to make it possible to notify the user of what happened, I added a facility for `GlobalStateSnapshot` to send *messages* to the client indicating what happened. There may be a cleaner way to do this as well but I wasn't sure exactly what might be best given this is my first time in this codebase. It may be worth, longer term, working with `rustup` to provide a way to detect a missing component binary since `rustup` returns `1` if `rustfmt` is not installed, which is not ideal. Co-authored-by: Daniel Silverstone <dsilvers@digital-scurf.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just running 'try' on this presently. should be completely routine.
r? @brson