Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Stop stripping empty modules - #42592
Merged
Merged
Conversation
rust-highfive
commented
Jun 11, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
There is no good reason to strip empty modules with no documentation and doing so causes subtle problems.
ollie27force-pushed
the
rustdoc_empty_modules
branch
from
June 11, 2017 17:26
5ece1a4 to
7298dabComparesteveklabnik
commented
Jun 12, 2017
Contributor
@bors: r+ seems good to me, thanks! |
bors
commented
Jun 12, 2017
Collaborator
📌 Commit 7298dab has been approved by |
bors
commented
Jun 12, 2017
Collaborator
⌛ Testing commit 7298dab with merge 58beb20... |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Jun 12, 2017
…eveklabnik rustdoc: Stop stripping empty modules There is no good reason to strip empty modules with no documentation and doing so causes subtle problems. Fixesrust-lang#42590
frewsxcv
commented
Jun 12, 2017
Contributor
@bors retry prioritizing rollup |
bors
commented
Jun 12, 2017
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no good reason to strip empty modules with no documentation and
doing so causes subtle problems.
Fixes#42590