New error codes

[GuillaumeGomez]

Part of #42229.

cc @Susurrus@frewsxcv@QuietMisdreavus

[rust-highfive]

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

[Susurrus]

Should be "Attempted to access a private field on a tuple-struct."

[Susurrus]

Use "make" instead of "set"

[Susurrus]

Instead "add a getter function to keep the field private but allow for accessing its value:".

[Susurrus]

I'd suggest using "n" here instead of "x" as "n" is commonly used for referring to integer values.

[Susurrus]

Instead "If you want to index into an array, use [] instead:"

[Susurrus]

Too many commas and incorrect conjugation. Instead "However, if you wanted to access a field of a struct check that the field name is spelled correctly."

[Susurrus]

Instead "Attempted to access a private field on a struct."

[Susurrus]

Instead: "1) Set the field public:"

I don't like the double-colons on this line.

[Susurrus]

Instead "2) Add a getter function:"

[Susurrus]

I suggest instead: "attempted to access tuple index {} on type {}, but the type is not a tuple or tuple struct"

[GuillaumeGomez]

@Susurrus: Thanks a lot for this review! Updated. :)

[frewsxcv]

Travis found some errors

[frewsxcv]

index into a slice

would this be more accurate?

[GuillaumeGomez]

I wanted to include both Vec and slices.

[pnkfelix]

In the context of Rust, when I see the term "array" I often think of fixed-length arrays [T; n]. But I don't have a better term on hand that covers the cases here, so this is fine with me.

[frewsxcv]

If you want to access a field of a struct, ensure the field's name is spelled correctly

this sounds better to me, but i don't feel strongly

[bors]

☔ The latest upstream changes (presumably #42644) made this pull request unmergeable. Please resolve the merge conflicts.

[GuillaumeGomez]

Rebased.

[QuietMisdreavus]

Would it be worth combining E0611 (private field access, tuple struct) and E0616 (private field access, traditional struct)? From the user's perspective, it's the same error, just in different situations.

(EDIT: For any infra team members who see this in a week, I believe imperio just left for a 10-day vacation, so updates on this will likely wait until he's come back from that.)

[alexcrichton]

ping @pnkfelix, I think this is ready for a re-review

[pnkfelix]

@bors r+

[bors]

📌 Commit ee60064 has been approved by pnkfelix

[bors]

⌛ Testing commit ee60064 with merge bd62230...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing bd62230 to master...