Skip to content

Update older URLs pointing to the first edition of the Book - #42623

Merged
bors merged 1 commit into
rust-lang:masterfrom
tirr-c:fix-older-urls
Jun 15, 2017
Merged

Update older URLs pointing to the first edition of the Book#42623
bors merged 1 commit into
rust-lang:masterfrom
tirr-c:fix-older-urls

Conversation

@tirr-c

@tirr-ctirr-c commented Jun 13, 2017

Copy link
Copy Markdown
Contributor

Fixes#42589.

@rust-highfive

rust-highfive commented Jun 13, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb

eddyb commented Jun 13, 2017

Copy link
Copy Markdown
Contributor

r? @steveklabnik

@arielb1arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2017
@arielb1

arielb1 commented Jun 13, 2017

Copy link
Copy Markdown
Contributor

Thanks for the PR @VBChunguk! @steveklabnik (or someone else) will be reviewing your PR soon.

@bors

bors commented Jun 14, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #42523) made this pull request unmergeable. Please resolve the merge conflicts.

@tirr-c
Update older URLs pointing to the first edition of the Book
3cb7825
`compiler-plugins.html` is moved into the Unstable Book.
Explanation is slightly modified to match the change.
@steveklabnik

steveklabnik commented Jun 14, 2017

Copy link
Copy Markdown
Contributor

r=me when travis passes. Thanks @VBChunguk !

@GuillaumeGomez

GuillaumeGomez commented Jun 15, 2017

Copy link
Copy Markdown
Member

@bors: r=steveklabnik

@bors

bors commented Jun 15, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 3cb7825 has been approved by steveklabnik

@bors

bors commented Jun 15, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3cb7825 with merge 16c27bf...

bors added a commit that referenced this pull request Jun 15, 2017
@bors
Auto merge of#42623- VBChunguk:fix-older-urls, r=steveklabnik
16c27bf
Update older URLs pointing to the first edition of the Book
Fixes#42589.
@bors

bors commented Jun 15, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing 16c27bf to master...

@bors
bors merged commit 3cb7825 into rust-lang:masterJun 15, 2017
@tirr-c
tirr-c deleted the fix-older-urls branch June 15, 2017 12:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tirr-c@rust-highfive@eddyb@arielb1@bors@steveklabnik@GuillaumeGomez
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update older URLs pointing to the first edition of the Book by tirr-c · Pull Request #42623 · rust-lang/rust · GitHub
Skip to content
Update older URLs pointing to the first edition of the Book - #42623
Merged
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Jun 15, 2017
Merged
Update older URLs pointing to the first edition of the Book#42623
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Conversation
@tirr-c
@tirr-ctirr-c
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Fixes#42589.
@rust-highfive
rust-highfive
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
@eddyb
eddyb
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
r? @steveklabnik
@arielb1arielb1
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 13, 2017
@arielb1
arielb1
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the PR @VBChunguk! @steveklabnik (or someone else) will be reviewing your PR soon.
@bors
bors
commented
Jun 14, 2017

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #42523) made this pull request unmergeable. Please resolve the merge conflicts.
@tirr-c
Update older URLs pointing to the first edition of the Book
3cb7825
`compiler-plugins.html` is moved into the Unstable Book.
Explanation is slightly modified to match the change.
@steveklabnik
steveklabnik
commented
Jun 14, 2017

Copy link


Copy Markdown

Contributor
r=me when travis passes. Thanks @VBChunguk !
@GuillaumeGomez
GuillaumeGomez
commented
Jun 15, 2017

Copy link


Copy Markdown

Member
@bors: r=steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
📌 Commit 3cb7825 has been approved by steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 3cb7825 with merge 16c27bf...
bors added a commit
that referenced
this pull request
Jun 15, 2017
@bors
Auto merge of#42623- VBChunguk:fix-older-urls, r=steveklabnik
16c27bf
Update older URLs pointing to the first edition of the Book
Fixes#42589.
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
☀️ Test successful - status-appveyor, status-travis

Approved by: steveklabnik

Pushing 16c27bf to master...
@bors
bors
merged commit 3cb7825
into
rust-lang:masterJun 15, 2017
@tirr-c
tirr-c
deleted the

fix-older-urls

branch
June 15, 2017 12:41
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@tirr-c@rust-highfive@eddyb@arielb1@bors@steveklabnik@GuillaumeGomez

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update older URLs pointing to the first edition of the Book by tirr-c · Pull Request #42623 · rust-lang/rust · GitHub
Skip to content
Update older URLs pointing to the first edition of the Book - #42623
Merged
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Jun 15, 2017
Merged
Update older URLs pointing to the first edition of the Book#42623
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Conversation
@tirr-c
@tirr-ctirr-c
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Fixes#42589.
@rust-highfive
rust-highfive
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
@eddyb
eddyb
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
r? @steveklabnik
@arielb1arielb1
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 13, 2017
@arielb1
arielb1
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the PR @VBChunguk! @steveklabnik (or someone else) will be reviewing your PR soon.
@bors
bors
commented
Jun 14, 2017

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #42523) made this pull request unmergeable. Please resolve the merge conflicts.
@tirr-c
Update older URLs pointing to the first edition of the Book
3cb7825
`compiler-plugins.html` is moved into the Unstable Book.
Explanation is slightly modified to match the change.
@steveklabnik
steveklabnik
commented
Jun 14, 2017

Copy link


Copy Markdown

Contributor
r=me when travis passes. Thanks @VBChunguk !
@GuillaumeGomez
GuillaumeGomez
commented
Jun 15, 2017

Copy link


Copy Markdown

Member
@bors: r=steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
📌 Commit 3cb7825 has been approved by steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 3cb7825 with merge 16c27bf...
bors added a commit
that referenced
this pull request
Jun 15, 2017
@bors
Auto merge of#42623- VBChunguk:fix-older-urls, r=steveklabnik
16c27bf
Update older URLs pointing to the first edition of the Book
Fixes#42589.
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
☀️ Test successful - status-appveyor, status-travis

Approved by: steveklabnik

Pushing 16c27bf to master...
@bors
bors
merged commit 3cb7825
into
rust-lang:masterJun 15, 2017
@tirr-c
tirr-c
deleted the

fix-older-urls

branch
June 15, 2017 12:41
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@tirr-c@rust-highfive@eddyb@arielb1@bors@steveklabnik@GuillaumeGomez

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update older URLs pointing to the first edition of the Book by tirr-c · Pull Request #42623 · rust-lang/rust · GitHub
Skip to content
Update older URLs pointing to the first edition of the Book - #42623
Merged
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Jun 15, 2017
Merged
Update older URLs pointing to the first edition of the Book#42623
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Conversation
@tirr-c
@tirr-ctirr-c
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Fixes#42589.
@rust-highfive
rust-highfive
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
@eddyb
eddyb
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
r? @steveklabnik
@arielb1arielb1
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 13, 2017
@arielb1
arielb1
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the PR @VBChunguk! @steveklabnik (or someone else) will be reviewing your PR soon.
@bors
bors
commented
Jun 14, 2017

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #42523) made this pull request unmergeable. Please resolve the merge conflicts.
@tirr-c
Update older URLs pointing to the first edition of the Book
3cb7825
`compiler-plugins.html` is moved into the Unstable Book.
Explanation is slightly modified to match the change.
@steveklabnik
steveklabnik
commented
Jun 14, 2017

Copy link


Copy Markdown

Contributor
r=me when travis passes. Thanks @VBChunguk !
@GuillaumeGomez
GuillaumeGomez
commented
Jun 15, 2017

Copy link


Copy Markdown

Member
@bors: r=steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
📌 Commit 3cb7825 has been approved by steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 3cb7825 with merge 16c27bf...
bors added a commit
that referenced
this pull request
Jun 15, 2017
@bors
Auto merge of#42623- VBChunguk:fix-older-urls, r=steveklabnik
16c27bf
Update older URLs pointing to the first edition of the Book
Fixes#42589.
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
☀️ Test successful - status-appveyor, status-travis

Approved by: steveklabnik

Pushing 16c27bf to master...
@bors
bors
merged commit 3cb7825
into
rust-lang:masterJun 15, 2017
@tirr-c
tirr-c
deleted the

fix-older-urls

branch
June 15, 2017 12:41
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@tirr-c@rust-highfive@eddyb@arielb1@bors@steveklabnik@GuillaumeGomez

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Update older URLs pointing to the first edition of the Book by tirr-c · Pull Request #42623 · rust-lang/rust · GitHub
Skip to content
Update older URLs pointing to the first edition of the Book - #42623
Merged
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Jun 15, 2017
Merged
Update older URLs pointing to the first edition of the Book#42623
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Conversation
@tirr-c
@tirr-ctirr-c
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Fixes#42589.
@rust-highfive
rust-highfive
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
@eddyb
eddyb
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
r? @steveklabnik
@arielb1arielb1
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 13, 2017
@arielb1
arielb1
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the PR @VBChunguk! @steveklabnik (or someone else) will be reviewing your PR soon.
@bors
bors
commented
Jun 14, 2017

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #42523) made this pull request unmergeable. Please resolve the merge conflicts.
@tirr-c
Update older URLs pointing to the first edition of the Book
3cb7825
`compiler-plugins.html` is moved into the Unstable Book.
Explanation is slightly modified to match the change.
@steveklabnik
steveklabnik
commented
Jun 14, 2017

Copy link


Copy Markdown

Contributor
r=me when travis passes. Thanks @VBChunguk !
@GuillaumeGomez
GuillaumeGomez
commented
Jun 15, 2017

Copy link


Copy Markdown

Member
@bors: r=steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
📌 Commit 3cb7825 has been approved by steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 3cb7825 with merge 16c27bf...
bors added a commit
that referenced
this pull request
Jun 15, 2017
@bors
Auto merge of#42623- VBChunguk:fix-older-urls, r=steveklabnik
16c27bf
Update older URLs pointing to the first edition of the Book
Fixes#42589.
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
☀️ Test successful - status-appveyor, status-travis

Approved by: steveklabnik

Pushing 16c27bf to master...
@bors
bors
merged commit 3cb7825
into
rust-lang:masterJun 15, 2017
@tirr-c
tirr-c
deleted the

fix-older-urls

branch
June 15, 2017 12:41
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@tirr-c@rust-highfive@eddyb@arielb1@bors@steveklabnik@GuillaumeGomez

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update older URLs pointing to the first edition of the Book by tirr-c · Pull Request #42623 · rust-lang/rust · GitHub
Skip to content
Update older URLs pointing to the first edition of the Book - #42623
Merged
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Jun 15, 2017
Merged
Update older URLs pointing to the first edition of the Book#42623
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Conversation
@tirr-c
@tirr-ctirr-c
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Fixes#42589.
@rust-highfive
rust-highfive
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
@eddyb
eddyb
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
r? @steveklabnik
@arielb1arielb1
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 13, 2017
@arielb1
arielb1
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the PR @VBChunguk! @steveklabnik (or someone else) will be reviewing your PR soon.
@bors
bors
commented
Jun 14, 2017

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #42523) made this pull request unmergeable. Please resolve the merge conflicts.
@tirr-c
Update older URLs pointing to the first edition of the Book
3cb7825
`compiler-plugins.html` is moved into the Unstable Book.
Explanation is slightly modified to match the change.
@steveklabnik
steveklabnik
commented
Jun 14, 2017

Copy link


Copy Markdown

Contributor
r=me when travis passes. Thanks @VBChunguk !
@GuillaumeGomez
GuillaumeGomez
commented
Jun 15, 2017

Copy link


Copy Markdown

Member
@bors: r=steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
📌 Commit 3cb7825 has been approved by steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 3cb7825 with merge 16c27bf...
bors added a commit
that referenced
this pull request
Jun 15, 2017
@bors
Auto merge of#42623- VBChunguk:fix-older-urls, r=steveklabnik
16c27bf
Update older URLs pointing to the first edition of the Book
Fixes#42589.
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
☀️ Test successful - status-appveyor, status-travis

Approved by: steveklabnik

Pushing 16c27bf to master...
@bors
bors
merged commit 3cb7825
into
rust-lang:masterJun 15, 2017
@tirr-c
tirr-c
deleted the

fix-older-urls

branch
June 15, 2017 12:41
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@tirr-c@rust-highfive@eddyb@arielb1@bors@steveklabnik@GuillaumeGomez

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Update older URLs pointing to the first edition of the Book by tirr-c · Pull Request #42623 · rust-lang/rust · GitHub
Skip to content
Update older URLs pointing to the first edition of the Book - #42623
Merged
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Jun 15, 2017
Merged
Update older URLs pointing to the first edition of the Book#42623
bors merged 1 commit into
rust-lang:masterfrom 
tirr-c:fix-older-urls
Conversation
@tirr-c
@tirr-ctirr-c
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Fixes#42589.
@rust-highfive
rust-highfive
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
@eddyb
eddyb
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
r? @steveklabnik
@arielb1arielb1
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 13, 2017
@arielb1
arielb1
commented
Jun 13, 2017

Copy link


Copy Markdown

Contributor
Thanks for the PR @VBChunguk! @steveklabnik (or someone else) will be reviewing your PR soon.
@bors
bors
commented
Jun 14, 2017

Copy link


Copy Markdown

Collaborator
☔ The latest upstream changes (presumably #42523) made this pull request unmergeable. Please resolve the merge conflicts.
@tirr-c
Update older URLs pointing to the first edition of the Book
3cb7825
`compiler-plugins.html` is moved into the Unstable Book.
Explanation is slightly modified to match the change.
@steveklabnik
steveklabnik
commented
Jun 14, 2017

Copy link


Copy Markdown

Contributor
r=me when travis passes. Thanks @VBChunguk !
@GuillaumeGomez
GuillaumeGomez
commented
Jun 15, 2017

Copy link


Copy Markdown

Member
@bors: r=steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
📌 Commit 3cb7825 has been approved by steveklabnik
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 3cb7825 with merge 16c27bf...
bors added a commit
that referenced
this pull request
Jun 15, 2017
@bors
Auto merge of#42623- VBChunguk:fix-older-urls, r=steveklabnik
16c27bf
Update older URLs pointing to the first edition of the Book
Fixes#42589.
@bors
bors
commented
Jun 15, 2017

Copy link


Copy Markdown

Collaborator
☀️ Test successful - status-appveyor, status-travis

Approved by: steveklabnik

Pushing 16c27bf to master...
@bors
bors
merged commit 3cb7825
into
rust-lang:masterJun 15, 2017
@tirr-c
tirr-c
deleted the

fix-older-urls

branch
June 15, 2017 12:41
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@tirr-c@rust-highfive@eddyb@arielb1@bors@steveklabnik@GuillaumeGomez