Add a travis builder for wasm32-unknown-emscripten by malbarbo · Pull Request #42631 · rust-lang/rust

malbarbo · 2017-06-13T14:04:25Z

This commits add an entry to travis matrix that will execute wasm32-unknown-emscripten tests suites.

Emscripten for asmjs was updated to sdk-1.37.13-64bit
The tests are run with node 8.0.0 (it can execute wasm)
A wrapper script is used to run each test from the directory where it is (workaround for Running wasm output via node does not work when in a different directory emscripten-core/emscripten#4542)
Some tests are ignore, see f32::rem fails on wasm32-unknown-emscripten #42629 and float tests fails on wasm32-unknown-emscripten #42630

- rename emscripten docker image to asmjs - create wasm32 docker image

Files with extensions .asm.js are used to generate .wasm files, they are not intented to be execute.

See rust-lang#42629 and rust-lang#42630.

rust-highfive · 2017-06-13T14:04:36Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

malbarbo · 2017-06-13T14:05:20Z

This is an alternative to #42059

malbarbo · 2017-06-13T14:07:39Z

r? @alexcrichton

We are running out of builders... but testing wasm32 in the same builder of asmjs would take too much time.

alexcrichton · 2017-06-13T18:14:18Z

Looks awesome, thanks for this! I think that the cwd business could be fixed as well with #42059, right?

Perhaps this could add a disabled/wasm/Dockerfile for now to land immediately and we could have a future PR to enable?

malbarbo · 2017-06-13T19:08:58Z

I think that the cwd business could be fixed as well with #42059, right?

I think so.

Perhaps this could add a disabled/wasm/Dockerfile for now to land immediately and we could have a future PR to enable?

Ok. Can we try this before to confirm it works on travis?

alexcrichton · 2017-06-13T19:12:25Z

Sure yeah! Want to just tag it with ALLOW_PR=1 on this pr? That way the PR builds should run the travis build.

alexcrichton · 2017-06-13T21:44:14Z

Timeout :(

If you run ./src/ci/docker/run.sh wasm though that should be equivalent to Travis? (if that passes locally I'd be pretty confident it'd pass remotely)

malbarbo · 2017-06-13T22:04:03Z

It passes locally. I will move the image to disabled.

malbarbo · 2017-06-13T22:15:04Z

Done.

alexcrichton · 2017-06-13T22:17:48Z

@bors: r+

bors · 2017-06-13T22:17:49Z

📌 Commit 9da77b3 has been approved by alexcrichton

bors · 2017-06-15T09:11:35Z

⌛ Testing commit 9da77b3 with merge 915b4ae...

bors · 2017-06-15T09:52:08Z

💔 Test failed - status-appveyor

Mark-Simulacrum · 2017-06-15T13:25:15Z

@bors retry

Failure appears spurious, possibly git/network related #42117

bors · 2017-06-15T15:09:08Z

⌛ Testing commit 9da77b3 with merge 2057edf...

bors · 2017-06-15T18:28:04Z

💔 Test failed - status-travis

est31 · 2017-06-15T18:29:57Z

@bors retry

spurious mac timeout

alexcrichton · 2017-06-15T18:31:17Z

@bors: retry * osx timed out

…

On Thu, Jun 15, 2017 at 1:28 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/243303924?utm_source=github_status&utm_medium=notification> — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#42631 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95AxLz1cRzNRGYxY29m0UkJYx0wM6ks5sEXfLgaJpZM4N4ilO> .

bors · 2017-06-16T07:55:05Z

⌛ Testing commit 9da77b3 with merge c3627e2...

Add a travis builder for wasm32-unknown-emscripten This commits add an entry to travis matrix that will execute wasm32-unknown-emscripten tests suites. - Emscripten for asmjs was updated to sdk-1.37.13-64bit - The tests are run with node 8.0.0 (it can execute wasm) - A wrapper script is used to run each test from the directory where it is (workaround for emscripten-core/emscripten#4542) - Some tests are ignore, see #42629 and #42630

bors · 2017-06-16T10:07:54Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c3627e2 to master...

malbarbo added 5 commits June 13, 2017 09:32

Add docker image for wasm32-unknown-emscripten
9b88a1b
- rename emscripten docker image to asmjs - create wasm32 docker image

Do not execute .asm.js files on wasm32 tests
554f21b
Files with extensions .asm.js are used to generate .wasm files, they are not intented to be execute.

Ignore some failing test on wasm32-unknown-emscripten
405adb6
See rust-lang#42629 and rust-lang#42630.

travis: Enable wasm32-unknown-emscripten tests
f0c400b

Add missing emscripten.sh file
dd0727f

rust-highfive assigned nikomatsakis Jun 13, 2017

rust-highfive assigned alexcrichton and unassigned nikomatsakis Jun 13, 2017

Make tidy happy
35d6eb3

malbarbo mentioned this pull request Jun 13, 2017
Make compiletest set cwd before running js tests #42059
Merged

Let's try
124ad70

arielb1 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 13, 2017

malbarbo mentioned this pull request Jun 13, 2017
Enable testing wasm32-unknown-emscripten on travis #42646
Closed

Disable wasm32 image
9da77b3

bors merged commit 9da77b3 into rust-lang:masterJun 16, 2017

bors mentioned this pull request Jun 16, 2017
Refactor dockerfiles to have a common base image. #42691
Closed

alexcrichton mentioned this pull request Jun 19, 2017
Enable wasm LLVM backend #42571
Merged

malbarbo deleted the wasm32 branch October 25, 2017 16:38

malbarbo restored the wasm32 branch October 25, 2017 16:39

Uh oh!

Uh oh!

Conversation

malbarbo commented Jun 13, 2017

Uh oh!

rust-highfive commented Jun 13, 2017

Uh oh!

malbarbo commented Jun 13, 2017

Uh oh!

malbarbo commented Jun 13, 2017

Uh oh!

alexcrichton commented Jun 13, 2017

Uh oh!

malbarbo commented Jun 13, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcrichton commented Jun 13, 2017

Uh oh!

alexcrichton commented Jun 13, 2017

Uh oh!

malbarbo commented Jun 13, 2017

Uh oh!

malbarbo commented Jun 13, 2017

Uh oh!

alexcrichton commented Jun 13, 2017

Uh oh!

bors commented Jun 13, 2017

Uh oh!

bors commented Jun 15, 2017

Uh oh!

bors commented Jun 15, 2017

Uh oh!

Mark-Simulacrum commented Jun 15, 2017

Uh oh!

bors commented Jun 15, 2017

Uh oh!

bors commented Jun 15, 2017

Uh oh!

est31 commented Jun 15, 2017

Uh oh!

alexcrichton commented Jun 15, 2017 via email

Uh oh!

bors commented Jun 16, 2017

Uh oh!

bors commented Jun 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

malbarbo commented Jun 13, 2017•
edited
Loading