Skip to content

Allow setting the limit on std::io::Take. - #42697

Merged
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:take-limit
Jul 12, 2017
Merged

Allow setting the limit on std::io::Take.#42697
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:take-limit

Conversation

@Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum commented Jun 16, 2017

Copy link
Copy Markdown
Member

Fixes#27269.

@Mark-SimulacrumMark-Simulacrum added the T-libs-api [DEPRECATED; DO NOT USE] label Jun 16, 2017
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum

Copy link
Copy Markdown
MemberAuthor

Arguably this can also be not implemented since out-of-tree implementation should involve no more than take.into_inner().take(new_limit), though this is more ergonomic (&mut self vs self).

@sfackler

Copy link
Copy Markdown
Member

This seems reasonable to me - might be worth explicitly mentioning that it doesn't "reset" the count of what's been read?

@rfcbot fcp merge

@Mark-Simulacrum

Copy link
Copy Markdown
MemberAuthor

I'll fix the code if we decide to move forward with this, hopefully landing after #42612.

@rfcbot

rfcbot commented Jun 16, 2017

Copy link
Copy Markdown

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@alexcrichton

Copy link
Copy Markdown
Member

ping @aturon / @brson on checkboxes

@Mark-Simulacrum

Copy link
Copy Markdown
MemberAuthor

@brson I believe this is only waiting on approval from you, will push a fix for the nit @sfackler noted with regards to docs.

@carols10cents

Copy link
Copy Markdown
Member

ping @brson, still waiting for your checkbox here!

Comment threadsrc/libstd/io/mod.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"do not affect the effect" is a somewhat confusing phrasing. Also missing period.

@aturon

Copy link
Copy Markdown
Contributor

@Mark-Simulacrum

Left a nit, otherwise r=me

@Mark-Simulacrum

Copy link
Copy Markdown
MemberAuthor

Fixed the nit (I think). @brson hasn't checked off yet, so I'm hesitant to r+ without that.

@aturon

Copy link
Copy Markdown
Contributor

@bors: r+

@Mark-Simulacrum for PRs (rather than RFCs), after a week if most folks have signed off we go forward.

@bors

bors commented Jul 12, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 7109d03 has been approved by aturon

@bors

bors commented Jul 12, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7109d03 with merge 8ac29bd...

bors added a commit that referenced this pull request Jul 12, 2017
Allow setting the limit on std::io::Take.
Fixes#27269.
@bors

bors commented Jul 12, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 8ac29bd to master...

@bors
bors merged commit 7109d03 into rust-lang:masterJul 12, 2017
@Mark-Simulacrum
Mark-Simulacrum deleted the take-limit branch January 17, 2018 23:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Mark-Simulacrum@rust-highfive@sfackler@rfcbot@alexcrichton@carols10cents@aturon@bors